-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default_value for required arguments #602
Conversation
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
Could you fix the conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see config_file
instances to be updated in:
- ros_gz_bridge/launch/ros_gz_bridge.launch
- ros_gz_bridge/launch/ros_gz_bridge.launch.py
* Add argument bridge_name to fix errors Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Changed |
Signed-off-by: Aarav Gupta <[email protected]>
Naming is hard but I thought |
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
I think now there are no more changes to be made. Can this merged? |
Signed-off-by: Aarav Gupta <[email protected]>
* Remove default_value for config_file Signed-off-by: Aarav Gupta <[email protected]>
* Remove default_value for config_file Signed-off-by: Aarav Gupta <[email protected]>
🦟 Bug fix
Removes
default_value
forconfig_file
andbridge_name
due to them being a required argument.Changes
string
andxml_string
toworld_string
in various places to maintain consistency, make clarification, and make fixes.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.