Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_value for required arguments #602

Merged
merged 11 commits into from
Sep 11, 2024

Conversation

Amronos
Copy link
Contributor

@Amronos Amronos commented Sep 6, 2024

🦟 Bug fix

Removes default_value for config_file and bridge_name due to them being a required argument.
Changes string and xml_string to world_string in various places to maintain consistency, make clarification, and make fixes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Could you fix the conflicts?

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see config_file instances to be updated in:

  • ros_gz_bridge/launch/ros_gz_bridge.launch
  • ros_gz_bridge/launch/ros_gz_bridge.launch.py

@Amronos Amronos requested a review from caguero September 7, 2024 03:17
Signed-off-by: Aarav Gupta <[email protected]>
@Amronos
Copy link
Contributor Author

Amronos commented Sep 8, 2024

Changed xml_string to string in various places to maintain consistency and make fixes. Please review that too.

@Amronos Amronos mentioned this pull request Sep 8, 2024
9 tasks
@caguero
Copy link
Contributor

caguero commented Sep 9, 2024

Changed xml_string to string in various places to maintain consistency and make fixes. Please review that too.

Naming is hard but I thought xml_string was a lightly better name than string. Maybe sdf_string is better? I don't have a strong opinion here :) . Maybe world_string?

@Amronos
Copy link
Contributor Author

Amronos commented Sep 9, 2024

I think now there are no more changes to be made. Can this merged?

Signed-off-by: Aarav Gupta <[email protected]>
@caguero caguero merged commit 7e0c94c into gazebosim:ros2 Sep 11, 2024
3 checks passed
@Amronos Amronos deleted the remove-default-values branch September 11, 2024 17:49
Amronos added a commit to Amronos/ros_gz that referenced this pull request Sep 12, 2024
* Remove default_value for config_file
Signed-off-by: Aarav Gupta <[email protected]>
Amronos added a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
* Remove default_value for config_file
Signed-off-by: Aarav Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants