Create ros_gz_spawn_model.launch #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
caguero
reviewed
Sep 9, 2024
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
|
We'll have to wait to merge this patch right after the Gazebo Ionic release considering that isn't fixing a critical but. |
Signed-off-by: Aarav Gupta <[email protected]>
8 tasks
Signed-off-by: Aarav Gupta <[email protected]>
|
Should be ready to merge now. |
|
https://github.com/Mergifyio backport jazzy |
🟠 Waiting for conditions to match
|
|
#622 Should also be backported to Jazzy. |
ahcorde
requested changes
Oct 28, 2024
Signed-off-by: Aarav Gupta <[email protected]>
ahcorde
approved these changes
Oct 28, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Aarav Gupta <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 02faa5b)
9 tasks
ahcorde
pushed a commit
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Aarav Gupta <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 02faa5b) Co-authored-by: Aarav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Created
ros_gz_spawn_model.launchtaking inspiration from files like ros_gz_sim.launch.Made to work after #606 is merged.
Test it
Something like the following command can be used:
ros2 launch ros_gz_sim ros_gz_spawn_model.launch world:=empty file:=$(ros2 pkg prefix --share ros_gz_sim_demos)/models/vehicle/model.sdf entity_name:=my_vehicle x:=5.0 y:=5.0 z:=0.5 bridge_name:=spawn_model_bridge config_file:=/path/to/config_fileChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.