Backport Some Changes from ros2 to jazzy #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward port of gazebosim#486. * Message and bridge for MaterialColor. This allows bridging MaterialColor from ROS to GZ and is important for allowing simulation users to create status lights. Signed-off-by: Benjamin Perseghetti <[email protected]>
* Add gzserver with ability to load an SDF file or string --------- Signed-off-by: Addisu Z. Taddese <[email protected]>
* Add gzserver with ability to load an SDF file or string Signed-off-by: Addisu Z. Taddese <[email protected]>
* Add gzserver with ability to load an SDF file or string Signed-off-by: Addisu Z. Taddese <[email protected]>
Spawn models from XML. Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
…osim#553) This also adds a required `name` parameter for the bridge so that multiple different bridges can be created without name collision Signed-off-by: Addisu Z. Taddese <[email protected]>
* Name is required. Signed-off-by: Carlos Agüero <[email protected]>
* Ignore local messages Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
While testing ros <-> gz communication using the bridge I noticed that the bridge was talking quite a bit of time copying images from Gazebo to ROS. I found that the std::copy operation that we're doing is substantially slower than the memcpy alternative. I think that in principle this shouldn't happen but the numbers are quite clear. Perhaps std::copy is doing something that doesn't use cache effectively --------- Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]>
Merge jazzy ➡️ ros2
Signed-off-by: Victor T. N. <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…imestamps_with_wall_time is set to true (gazebosim#562) Signed-off-by: Rein Appeldoorn <[email protected]>
Signed-off-by: Sebastian Kasperski <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Amronos <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
|
Any updates on this? |
* Add argument bridge_name to fix errors Signed-off-by: Aarav Gupta <[email protected]>
* Remove default_value for config_file Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
* Add argument bridge_name to fix errors Signed-off-by: Aarav Gupta <[email protected]>
* Remove default_value for config_file Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…m#606) * Change world_string to model_string Also changed description from XML string to XML(SDF) string Signed-off-by: Aarav Gupta <[email protected]>
…m#606) * Change world_string to model_string Also changed description from XML string to XML(SDF) string Signed-off-by: Aarav Gupta <[email protected]>
|
I am closing this pull request. I will make a new cleaner one later when everything happening right now with the ros2 branch gets a bit finalized. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #589
Summary
I have backported changes made in ros2 to jazzy which weren't already present in jazzy. Please tell me if anything is incorrect, or if the changes aren't supposed to be backported like this.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.