Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use model string in ros_gz_spawn_model.launch.py #605

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Use model string in ros_gz_spawn_model.launch.py #605

merged 2 commits into from
Sep 11, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Sep 11, 2024 •
edited
Loading

🦟 Bug fix

Replace world_string with model_string. This was renamed by mistake in #602 .

cc @Amronos

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero mentioned this pull request Sep 11, 2024
Merged
8 tasks
azeey
azeey requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the gz_spawn action?

I think a good follow-up would be to add tests to catch these types of mismatches.

@caguero
More model_string instances.
9e63f09 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Contributor Author

caguero commented Sep 11, 2024

Can you also update the gz_spawn action?

I think a good follow-up would be to add tests to catch these types of mismatches.

Updated in 9e63f09

@ahcorde ahcorde merged commit 66c7a4a into ros2 Sep 11, 2024
5 checks passed
@ahcorde ahcorde deleted the caguero/use_model_string branch September 11, 2024 19:51
@Amronos Amronos mentioned this pull request Sep 12, 2024
Merged
8 tasks
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 12, 2024
@caguero @Amronos
Use model string in ros_gz_spawn_model.launch.py (gazebosim#605)
e1106d7 
Signed-off-by: Carlos Agüero <[email protected]>
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
@caguero @Amronos
Use model string in ros_gz_spawn_model.launch.py (gazebosim#605)
c8fb8ba 
Signed-off-by: Carlos Agüero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caguero @azeey @ahcorde