Ophyd pin-tip centring

[Tom-Willemsen]

Requires DiamondLightSource/dodal#289

Provide support for running both Ophyd + AD MXSC pin tip centring workflows in hyperion.

To test:

• Confirm using the ophyd device is externally selectable
• Confirm the issues in Ophyd pin-tip centring #938 (comment) are addressed:
  • Ophyd pin tip: Write image on every read  dodal#290
  • Ophyd pin tip: Use for grid detection #1068
  • Ophyd pin tip: Trigger and wait for the device to find a pin #1069
• Confirm tests pass

[DominicOram]

Tested on beamline today. Broadly works but need to:

• Tidy up
• Direction is written in the JSON as 0, this expects +1 or -1
• Set the PVA plugin to look at PROC when at ZOOM 1, we won't need to do this if we get https://jira.diamond.ac.uk/browse/I03-912 done
• Allow turning this on to be user settable
• New issue - write a snapshot to file if no pin tip was found (must the same frame that was used for detection)
• Potentially new issue - use this device for the grid detection too

[Tom-Willemsen]

Handed over to @dperl-dls .

[DominicOram]

I'll pick this up now so that @dperl-dls can focus on rotation scan stuff

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d1e2d97) 93.35% compared to head (3dff9a9) 93.80%.
Report is 7 commits behind head on main.

❗ Current head 3dff9a9 differs from pull request most recent head aadbfa5. Consider uploading reports for the commit aadbfa5 to get more accurate results

Files	Patch %	Lines
...hyperion/experiment_plans/pin_tip_centring_plan.py	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   93.35%   93.80%   +0.44%     
==========================================
  Files          62       58       -4     
  Lines        2921     2759     -162     
==========================================
- Hits         2727     2588     -139     
+ Misses        194      171      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dperl-dls]

Looks good, thanks for tidying this up

[dperl-dls]

Do I understand correctly that this will be adressed in #1069?

[DominicOram]

Yep