Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ophyd pin tip centring #210

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Tom-Willemsen
Copy link
Contributor

Adds reference to pin tip centring ophyd-async device.

Supporting PR for DiamondLightSource/hyperion#938

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #210 (ffc45f9) into main (8f541cd) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   89.49%   89.47%   -0.03%     
==========================================
  Files          71       71              
  Lines        2437     2441       +4     
==========================================
+ Hits         2181     2184       +3     
- Misses        256      257       +1     
Files Coverage Δ
src/dodal/beamlines/i03.py 87.01% <75.00%> (-0.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review October 23, 2023 11:54
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks. We should have a think about codecov on these files as a whole and how useful it is

@Tom-Willemsen Tom-Willemsen merged commit f1046d9 into main Oct 23, 2023
14 of 16 checks passed
@Tom-Willemsen Tom-Willemsen deleted the allow_using_ophyd_pin_tip_centring branch October 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants