This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
No ispyb entry on failed pin tip centre #996
Comments
DominicOram
added
the
needed_for_release
Issues that must be complete before the next release
label
Nov 24, 2023
For hotfix of pin tip centre suggestion is to:
|
Ispyb error currently doesn't happen as we do the grid detection before we set up the xray centre grid callback. I think we should rethink this after we have the ispyb deposition on a separate process @dperl-dls |
5 tasks
Decided against saving images as until we do #938 we're not really guaranteed the image is correct anyway |
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 24, 2023
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 24, 2023
… and add more tests
2 tasks
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 24, 2023
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 27, 2023
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 27, 2023
DominicOram
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Nov 27, 2023
DominicOram
removed
the
needed_for_release
Issues that must be complete before the next release
label
Dec 4, 2023
DominicOram
changed the title
Failure to centre and no ispyb entry
No ispyb entry on failed pin tip centre
Dec 12, 2023
Once we have robot load in Hyperion the error should go in that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We saw a bug in https://ispyb.diamond.ac.uk/samples/sid/5054617 where the sample failed to centre and produced no ispyb entry saying what the issue was.
The logs suggest that Hyperion thought that the pin tip centre was correct but then failed to find the tip again for the grid calculations. By looking at the images for the rotation scan in ispyb (which is where Hyperion moved to after pin tip centre) it seems that the pin tip centring was actually quite far off (I suspect due to #924).
Acceptance Criteria
We make the pin tip centre more robust (maybe as a hotfix?)Done in Pin tip centring now takes a median of values dodal#242The text was updated successfully, but these errors were encountered: