Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

No ispyb entry on failed pin tip centre #996

Closed
DominicOram opened this issue Nov 24, 2023 · 4 comments
Closed

No ispyb entry on failed pin tip centre #996

DominicOram opened this issue Nov 24, 2023 · 4 comments
Assignees

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Nov 24, 2023

We saw a bug in https://ispyb.diamond.ac.uk/samples/sid/5054617 where the sample failed to centre and produced no ispyb entry saying what the issue was.

The logs suggest that Hyperion thought that the pin tip centre was correct but then failed to find the tip again for the grid calculations. By looking at the images for the rotation scan in ispyb (which is where Hyperion moved to after pin tip centre) it seems that the pin tip centring was actually quite far off (I suspect due to #924).

Acceptance Criteria

@DominicOram DominicOram self-assigned this Nov 24, 2023
@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Nov 24, 2023
@DominicOram
Copy link
Collaborator Author

For hotfix of pin tip centre suggestion is to:

  • Take a handful of readings then take the median in x and y to find a close centre.
  • Log the points and the deviations
  • Take images for each and put them somewhere on /dls/

@DominicOram
Copy link
Collaborator Author

Ispyb error currently doesn't happen as we do the grid detection before we set up the xray centre grid callback. I think we should rethink this after we have the ispyb deposition on a separate process @dperl-dls

@DominicOram
Copy link
Collaborator Author

Decided against saving images as until we do #938 we're not really guaranteed the image is correct anyway

DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 24, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 24, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 24, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 27, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 27, 2023
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 27, 2023
@DominicOram DominicOram removed the needed_for_release Issues that must be complete before the next release label Dec 4, 2023
@DominicOram DominicOram changed the title Failure to centre and no ispyb entry No ispyb entry on failed pin tip centre Dec 12, 2023
@DominicOram
Copy link
Collaborator Author

Once we have robot load in Hyperion the error should go in that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant