Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Ophyd pin tip: Trigger and wait for the device to find a pin #1069

Closed
DominicOram opened this issue Jan 14, 2024 · 1 comment · Fixed by DiamondLightSource/dodal#336 or #1151
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Collaborator

As of #938, if we don't find a pin from the ophyd pin detection we wait a second and try again. Instead we should trigger the pin tip detection and wait for it to find a valid pin with a timeout, this is more like how the AD pin tip detection works.

Acceptance Criteria

  • The ophyd pin tip detection allows triggering
  • When it is triggered it will only return when a valid pin is found or a timeout is reached
  • The subsequent read will return this valid position
@DominicOram DominicOram added the good first issue Good for newcomers label Jan 19, 2024
@DominicOram
Copy link
Collaborator Author

Once we do this we should be able to remove the wait_for_tip_to_be_found_ophyd specific function

@DominicOram DominicOram self-assigned this Feb 14, 2024
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Feb 14, 2024
DominicOram added a commit that referenced this issue Feb 14, 2024
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Feb 14, 2024
DominicOram added a commit that referenced this issue Feb 14, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
…he ophyd pin detection in the same way as the AD plugin
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
Archived in project
1 participant