Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Ophyd pin tip: Use for grid detection #1068

Closed
DominicOram opened this issue Jan 14, 2024 · 0 comments · Fixed by #1214
Closed

Ophyd pin tip: Use for grid detection #1068

DominicOram opened this issue Jan 14, 2024 · 0 comments · Fixed by #1214
Assignees
@dperl-dls

Comments

@DominicOram
Copy link
Collaborator

As of #938 we are using the ophyd OAV edge detection to find the pin tip during the pin tip centring. We should switch over to also using it for the grid detection as well when the GDA property is enabled.

Acceptance Criteria
@DominicOram DominicOram mentioned this issue Jan 14, 2024
Merged
@DominicOram DominicOram mentioned this issue Mar 4, 2024
Closed
@dperl-dls dperl-dls self-assigned this Mar 4, 2024
dperl-dls added a commit that referenced this issue Mar 4, 2024
@dperl-dls
#1068 update hyperion plans to use ophyd-async edge detect
c210d56
dperl-dls added a commit that referenced this issue Mar 4, 2024
@dperl-dls
#1068 fix some tests and oav mock
dfded7f
This was referenced Mar 4, 2024
Merged
Merged
dperl-dls added a commit that referenced this issue Mar 5, 2024
@dperl-dls
#1068 only set plugin in view if using MXSC
ff5073f
dperl-dls added a commit that referenced this issue Mar 5, 2024
@dperl-dls
#1068 fix test
84d15fb
dperl-dls added a commit that referenced this issue Mar 5, 2024
@dperl-dls
#1068 use wait for tip tp be found
e7d07e7
dperl-dls added a commit that referenced this issue Mar 5, 2024
@dperl-dls
#1068 update dodal ref
5250694
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 update hyperion plans to use ophyd-a…
253e3b8 
…sync edge detect
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 fix some tests and oav mock
2360bad
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 only set plugin in view if using MXSC
8c0be97
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 fix test
0e1ad8a
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 use wait for tip tp be found
1ca1b0f
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1068 update dodal ref
717092b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dperl-dls dperl-dls

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ophyd oav edge detetion for grid determination DiamondLightSource/hyperion
2 participants
@DominicOram @dperl-dls