[rubocop] Step 5 #214
Merged
[rubocop] Step 5 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because enabling it, even if it's recommended, require very careful tests and review to avoid accidental runtime crashes
Used RubyMine's refactoring feature to extract the big chunk of code building the entries into its private method, to reduce the self.run(…)'s complexity
AliSoftware
requested review from
a team,
oguzkocer,
jkmassel and
loremattei
and removed request for
a team
jkmassel
approved these changes
Feb 23, 2021
lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb
Show resolved
Hide resolved
| # Enabling the 'frozen_string_literal: true' comment is nice but should be done with extra care | ||
| # because enabling it on code that accidentally mutates string literals will crash at runtime | ||
| # (e.g. `name = 'Hello'` then later `name << ' world'` will crash if the comment is enabled) | ||
| # So we might enable it at some point, be we will need very careful review that this doesn't break everything. |
lib/fastlane/plugin/wpmreleasetoolkit/helper/an_metadata_update_helper.rb
Show resolved
Hide resolved
lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb
Outdated
Show resolved
Hide resolved
Change the setting of the rule from the default (no_comma) to consistent_comma, which better matches our style
|
Thanks for the review @jkmassel 👍 I should have addressed all your questions and suggestions 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work on #207 and rubocop.
This also includes a small refactor (consisting of the extraction of long portion of code into a separate method, to reduce the code complexity and method length, see f84285d) that might also need careful review – especially to ensure that all the variables used in the original code were all passed to the method and that the extracted code didn't modify any variable that would then later be used after it in the original code, etc.
The corresponding commits are labeled accordingly (
[rubocop] fix … (manual)and the like) – in case you want to review commit-per-commit.