Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into cleanup #215

Merged
merged 14 commits into from
Feb 24, 2021
Merged

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Feb 18, 2021

This re-syncs the new commits from develop with the toolkit-cleanup WIP branch.

This first requires #214 to be reviewed and merged, hence the Draft state for now.

How?

  • Merged develop into intermediate merge-develop-into-cleanup branch, cut from cleanup/rubocop/step5 to solve the conflicts.
  • Added some commits onto that merge-develop-into-cleanup branch to solve the new rubocop violations introduced by the new code from develop.
  • Once [rubocop] Step 5 #214 gets merged into cleanup-toolkit, GitHub should automatically update the base branch of this Merge develop into cleanup #215 PR to cleanup-toolkit, then I'll un-draft this PR.
┌───────────────┐
│cleanup-toolkit│───────○───────────────────────────────────────────────△─────────────▷
└───────────────┘        ╲                                             ╱
                          ╲        △ #214         PR base change
┌───────────────────────┐  ╲      ╱              when #214 merged    ╱
│ cleanup/rubocop/step5 │   ○────○ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─○─ ─ ─ ─▷
└───────────────────────┘         ╲                                △ #215
                                   ╲                   fix        ╱
                                    ╲        fix     rubocop
┌───────────────────────────┐        ╲     conflict violations  ╱
│merge-develop-into-cleanup │         ○────────◎─────────◎─────○
└───────────────────────────┘        ╱
                                    ╱
┌───────────────┐                  ╱
│    develop    │─────────────────○───────────────────────────────────────────────────▶
└───────────────┘

@AliSoftware AliSoftware self-assigned this Feb 18, 2021
@AliSoftware AliSoftware requested review from a team, oguzkocer, jkmassel and mokagio and removed request for a team February 19, 2021 12:34
@AliSoftware AliSoftware marked this pull request as ready for review February 24, 2021 10:15
Base automatically changed from cleanup/rubocop/step5 to toolkit-cleanup February 24, 2021 12:47
@AliSoftware AliSoftware merged commit 74a3982 into toolkit-cleanup Feb 24, 2021
@AliSoftware AliSoftware deleted the merge-develop-into-cleanup branch February 24, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants