-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into cleanup #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add action to trigger CI jobs via API
# Conflicts: # Gemfile # Gemfile.lock
AliSoftware
requested review from
a team,
oguzkocer,
jkmassel and
mokagio
and removed request for
a team
February 19, 2021 12:34
jkmassel
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-syncs the new commits from
develop
with thetoolkit-cleanup
WIP branch.This first requires #214 to be reviewed and merged, hence the Draft state for now.
How?
develop
into intermediatemerge-develop-into-cleanup
branch, cut fromcleanup/rubocop/step5
to solve the conflicts.merge-develop-into-cleanup
branch to solve the new rubocop violations introduced by the new code fromdevelop
.cleanup-toolkit
, GitHub should automatically update the base branch of this Merge develop into cleanup #215 PR tocleanup-toolkit
, then I'll un-draft this PR.