wordpress-mobile · AliSoftware · Feb 24, 2021 · Feb 18, 2021 · Feb 18, 2021 · Feb 18, 2021
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -464,13 +464,6 @@ Style/TernaryParentheses:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/configure_helper.rb'
 
-# Offense count: 20
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArrayLiteral:
-  Enabled: false
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb
@@ -51,7 +51,7 @@ def self.available_options
                                        env_name: 'CHECK_LIBS_DIFF_URL',
                                        description: 'The url of the diff to check',
                                        optional: true,
-                                       is_string: true),
+                                       is_string: true)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb
@@ -61,7 +61,7 @@ def self.available_options
                                        env_name: 'FL_ANDROID_BUILD_PRECHECKS_FINAL_BUILD',
                                        description: 'True if this is for a final build',
                                        is_string: false,
-                                       default_value: false),
+                                       default_value: false)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb
@@ -47,7 +47,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :locales,
                                        env_name: 'FL_DOWNLOAD_METADATA_LOCALES',
                                        description: 'The hash with the GLotPress locale and the project locale association',
-                                       is_string: false),
+                                       is_string: false)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb
@@ -86,7 +86,7 @@ def self.available_options
                                        env_name: 'AMTS_STRING_FOLDER',
                                        description: 'The folder that contains all the translations',
                                        optional: false,
-                                       type: String),
+                                       type: String)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/close_milestone_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/close_milestone_action.rb
@@ -44,7 +44,7 @@ def self.available_options
                                        env_name: 'GHHELPER_MILESTONE',
                                        description: 'The GitHub milestone',
                                        optional: false,
-                                       type: String),
+                                       type: String)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_new_milestone_action.rb
@@ -47,7 +47,7 @@ def self.available_options
                                        description: 'True if the app needs to be submitted',
                                        optional: true,
                                        is_string: false,
-                                       default_value: false),
+                                       default_value: false)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb
@@ -67,7 +67,7 @@ def self.available_options
                                        description: 'True if this is a pre-release',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       is_string: false)
         ]
       end
 

diff --git a/...tlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb b/...tlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb
@@ -77,7 +77,7 @@ def self.available_options
                                        env_name: 'GHHELPER_EXTRACT_NOTES_EXTRACTED_FILE_PATH',
                                        description: 'The path to the file that will contain the extracted release notes',
                                        optional: true,
-                                       is_string: true),
+                                       is_string: true)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/promo_screenshots_action.rb
@@ -166,7 +166,7 @@ def self.available_options
                                        description: 'Overwrite existing promo screenshots without asking first?',
                                        optional: true,
                                        is_string: false,
-                                       default_value: false),
+                                       default_value: false)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb
@@ -125,7 +125,7 @@ def self.available_options
                                        description: 'Overwrite copied files without confirmation',
                                        optional: true,
                                        default_value: false,
-                                       is_string: false),
+                                       is_string: false)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_validate_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_validate_action.rb
@@ -44,7 +44,7 @@ def self.validate_that_branches_match
 
           UI.user_error!([
             'The branch specified in `.configure` is not the currently checked out branch in the secrets repository.',
-            "To fix this issue, switch back to the `#{file_branch_name}` branch in the mobile secrets repository.",
+            "To fix this issue, switch back to the `#{file_branch_name}` branch in the mobile secrets repository."
           ].join("\n"))
         end
       end
@@ -59,7 +59,7 @@ def self.validate_that_hashes_match
 
           UI.user_error!([
             'The pinned_hash specified in `.configure` is not the currently checked out hash in the secrets repository.',
-            "To fix this issue, check out the `#{file_hash}` hash in the mobile secrets repository.",
+            "To fix this issue, check out the `#{file_hash}` hash in the mobile secrets repository."
           ].join("\n"))
         end
       end

diff --git a/...in/wpmreleasetoolkit/actions/ios/add_development_certificates_to_provisioning_profiles.rb b/...in/wpmreleasetoolkit/actions/ios/add_development_certificates_to_provisioning_profiles.rb
@@ -52,7 +52,7 @@ def self.available_options
                                        is_string: true,
                                        verify_block: proc do |value|
                                                        UI.user_error!('You must provide a team ID in `team_id`') unless value && (!value.empty?)
-                                                     end),
+                                                     end)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_devices_to_provisioning_profiles.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/add_devices_to_provisioning_profiles.rb
@@ -54,7 +54,7 @@ def self.available_options
             verify_block: proc do |value|
               UI.user_error!('You must provide a team ID in `team_id`') unless value && (!value.empty?)
             end
-          ),
+          )
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb
@@ -63,7 +63,7 @@ def self.available_options
                                        env_name: 'FL_IOS_CODEFREEZE_BUMP_SKIPDELIVER',
                                        description: 'Skips Deliver key update',
                                        is_string: false, # true: verifies the input is a string, false: every kind of value
-                                       default_value: false), # the default value if the user didn't provide one
+                                       default_value: false) # the default value if the user didn't provide one
 
         ]
       end

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb
@@ -39,7 +39,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :podfile,
                                        env_name: 'FL_IOS_CHECKBETADEPS_PODFILE',
                                        description: 'Path to the Podfile to analyse',
-                                       is_string: true),
+                                       is_string: true)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_store_app_sizes.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_store_app_sizes.rb
@@ -92,7 +92,7 @@ def self.available_options
             description: "The output format used to print the result. Can be one of 'csv' or 'markdown', or nil to print nothing (raw data will always be available as the the action's return value)",
             type: String,
             optional: true
-          ),
+          )
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_lint_localizations.rb
@@ -139,7 +139,7 @@ def self.available_options
             optional: true,
             default_value: false,
             is_string: false # https://docs.fastlane.tools/advanced/actions/#boolean-parameters
-          ),
+          )
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb
@@ -81,7 +81,7 @@ def self.available_options
                                        env_name: 'IMTS_STRING_FOLDER',
                                        description: 'The folder that contains all the translations',
                                        optional: false,
-                                       type: String),
+                                       type: String)
         ]
       end
 

diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb b/lib/fastlane/plugin/wpmreleasetoolkit/helper/promo_screenshots_helper.rb
@@ -373,7 +373,7 @@ def resolve_path(path)
           Pathname.new(path),                                                           # Absolute Path
           Pathname.new(FastlaneCore::FastlaneFolder.fastfile_path).dirname + path,      # Path Relative to the fastfile
           Fastlane::Helper::FilesystemHelper.plugin_root + path,                        # Path Relative to the plugin
-          Fastlane::Helper::FilesystemHelper.plugin_root + 'spec/test-data/' + path,    # Path Relative to the test data
+          Fastlane::Helper::FilesystemHelper.plugin_root + 'spec/test-data/' + path # Path Relative to the test data
         ]
           .each do |resolved_path|
           return resolved_path if !resolved_path.nil? && resolved_path.exist?