Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rubocop] Step 5 #214

Merged
merged 37 commits into from
Feb 24, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
9a604f2
[rubocop] fix Style/AndOr
AliSoftware Feb 18, 2021
3c24919
[rubocop] fix Style/BarePercentLiterals
AliSoftware Feb 18, 2021
604b017
[rubocop] fix Style/BlockDelimiters
AliSoftware Feb 18, 2021
70c7b6e
[rubocop] fix Style/BracesAroundHashParameters
AliSoftware Feb 18, 2021
75c9583
[rubocop] fix Style/ClassAndModuleChildren
AliSoftware Feb 18, 2021
a9d818d
[rubocop] fix Style/ClassCheck
AliSoftware Feb 18, 2021
3bb7aed
[rubocop] fix Style/ConditionalAssignment
AliSoftware Feb 18, 2021
bfb40c9
[rubocop] fix Style/DefWithParentheses
AliSoftware Feb 18, 2021
bda5e57
[rubocop] fix Style/EmptyLiteral
AliSoftware Feb 18, 2021
2a93320
[rubocop] configure Style/EmptyMethod
AliSoftware Feb 18, 2021
9c77eca
[rubocop] fix Style/Encoding
AliSoftware Feb 18, 2021
9f2c690
[rubocop] fix Style/ExpandPathArguments
AliSoftware Feb 18, 2021
4a56484
[rubocop] fix Style/FormatString
AliSoftware Feb 18, 2021
191e9e5
[rubocop] disable Style/FrozenStringLiteralComment
AliSoftware Feb 18, 2021
5830fc7
[rubocop] fix Style/HashSyntax
AliSoftware Feb 18, 2021
a882be7
[rubocop] fix Style/IfUnlessModifier
AliSoftware Feb 18, 2021
7fe4b1a
[rubocop] fix Style/InverseMethods
AliSoftware Feb 18, 2021
4cb320a
[rubocop] fix Style/ParenthesesAroundCondition
AliSoftware Feb 18, 2021
0250763
[rubocop] fix Style/MultilineIfThen
AliSoftware Feb 18, 2021
3750c49
[rubocop] fix Style/NegatedIf
AliSoftware Feb 18, 2021
0bc24dc
[rubocop] fix Style/NegatedUnless
AliSoftware Feb 18, 2021
79995c3
[rubocop] fix Style/NilComparison
AliSoftware Feb 18, 2021
6de7f59
[rubocop] fix Style/NonNilCheck (safe-auto-correct)
AliSoftware Feb 18, 2021
b7691b6
[rubocop] fix Style/NonNilCheck (manual fixes) ⚠️
AliSoftware Feb 18, 2021
f84285d
[rubocop] ⚠️ Manual fix of Metrics/AbcSize
AliSoftware Feb 18, 2021
27fd9d1
[rubocop] fix Style/Not
AliSoftware Feb 18, 2021
7976a90
[rubocop] fix Style/NumericLiteralPrefix
AliSoftware Feb 18, 2021
9d47d7d
[rubocop] fix Style/PercentLiteralDelimiters
AliSoftware Feb 18, 2021
461eb41
[rubocop] fix Style/RegexpLiteral
AliSoftware Feb 18, 2021
16a9ecb
[rubocop] fix Style/Semicolon
AliSoftware Feb 18, 2021
dc044c3
[rubocop] fix Style/StringLiteralsInInterpolation
AliSoftware Feb 18, 2021
9c5080d
[rubocop] fix Style/TrailingCommaInArguments
AliSoftware Feb 18, 2021
3b6252c
[rubocop] fix Style/TrailingCommaInArrayLiteral
AliSoftware Feb 18, 2021
17b1e76
[rubocop] fix Style/TrailingCommaInHashLiteral
AliSoftware Feb 18, 2021
4492cc7
Add comment about octal notation for chmod-like flags
AliSoftware Feb 24, 2021
f6499f7
[rubocop] fix Style/TrailingCommaInArrayLiteral
AliSoftware Feb 24, 2021
fd8d9bd
build_entries doesn't need the whole config Hash
AliSoftware Feb 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ Lint/UnusedMethodArgument:
Style/EmptyMethod:
EnforcedStyle: expanded

# Enabling the 'frozen_string_literal: true' comment is nice but should be done with extra care
# because enabling it on code that accidentally mutates string literals will crash at runtime
# (e.g. `name = 'Hello'` then later `name << ' world'` will crash if the comment is enabled)
# So we might enable it at some point, be we will need very careful review that this doesn't break everything.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Style/FrozenStringLiteralComment:
Enabled: false

########## Metrics / Max Lengths Rules

Metrics/LineLength:
Expand Down
7 changes: 0 additions & 7 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,6 @@ Style/AsciiComments:
Style/Documentation:
Enabled: false

# Offense count: 104
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, never
Style/FrozenStringLiteralComment:
Enabled: false

# Offense count: 4
# Configuration parameters: AllowedVariables.
Style/GlobalVars:
Expand Down