Update csr_access_test
#37
Conversation
Signed-off-by: Robin Pedersen <[email protected]>
silabs-robin
force-pushed
the
40x_yaml_todos
branch
from
8feeeb8
to
d5ef816
Compare
tests/programs/custom/cv32e40x_csr_access_test/cv32e40x_csr_access_test.S
Outdated
Show resolved
Hide resolved
tests/programs/custom/cv32e40x_csr_access_test/cv32e40x_csr_access_test.S
Show resolved
Hide resolved
tests/programs/custom/cv32e40x_csr_access_test/cv32e40x_csr_access_test.S
Show resolved
Hide resolved
tests/programs/custom/cv32e40x_csr_access_test/cv32e40x_csr_access_test.S
Show resolved
Hide resolved
silabs-robin
force-pushed
the
40x_yaml_todos
branch
from
6f03d62
to
d5ef816
Compare
Signed-off-by: Robin Pedersen <[email protected]>
| bne x7, x14, csr_fail | ||
| li x7, 0x5a5a5a5a | ||
| csrrc x14, 800, x7 | ||
| li x7, 0x00000008 |
There was a problem hiding this comment.
I dont understand this change. It seems like you change some values to 0, it that the purpose?
| @@ -25,35 +25,35 @@ _start0: | |||
| csrrw x14, 2816, x7 | |||
There was a problem hiding this comment.
You say that the csr_access test is updated. Could you give a quick recap on what are updated?
There was a problem hiding this comment.
This was updated: openhwgroup/cv32e40x#957
And... actually, in the 3 months since I PRed this, there was another update to that file. I will have to re-run the generation and run the test again.
Let's just leave this PR alone for now.
(Thanks for having a look at it, I'll see if I can squeeze in a fix this week or if it has to be postponed.)
For completeness:
After that Yaml change, then the regen script described in https://github.com/openhwgroup/cv32e40x-dv/pull/37/files#diff-43e71d36024fbe1d133827162b04bf6e64b864e979725f7c9f09f96562ccc09e was run.
That auto-generated the assembly file to match our most recent CSR definitions.
There was a problem hiding this comment.
Okei, I see. Thank you. Okei, then we leave it for now.
This PR regenerates the CSR access test.
Relates to openhwgroup/cv32e40x#940 and openhwgroup/core-v-verif#2186.
And openhwgroup/core-v-verif#2218 and openhwgroup/cv32e40x#957.
(The generated test of course passes.)