Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ROS node that runs Gazebo #500

Merged
merged 5 commits into from
May 22, 2024
Merged

Add a ROS node that runs Gazebo #500

merged 5 commits into from
May 22, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 21, 2024

🎉 New feature

Closes #497

Summary

  • Add gzserver with ability to load an SDF file or string

TODO

  • Add ability to load additional systems in addition to the ones loaded by default or as part of the SDF world
  • Configure SDFormat to understand package:// URIs

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey marked this pull request as ready for review May 22, 2024 17:16
@azeey azeey requested a review from ahcorde as a code owner May 22, 2024 17:16
@azeey azeey requested a review from caguero May 22, 2024 17:16
@azeey
Copy link
Contributor Author

azeey commented May 22, 2024

Since this is now a dependency of #528 and related PRs, I think it's best to merge it as is and work on the other TODO items in follow-up PRs. It would also be nice to add a test, but we are running short on time with the Jazzy release, so I propose we punt on that as well.

@azeey azeey merged commit 92a2891 into ros2 May 22, 2024
3 checks passed
@azeey azeey deleted the gz_sim_ros_node branch May 22, 2024 21:12
@azeey
Copy link
Contributor Author

azeey commented Jun 24, 2024

@Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Jun 24, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 24, 2024
* Add gzserver with ability to load an SDF file or string

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 92a2891)
ahcorde pushed a commit that referenced this pull request Jun 25, 2024
* Add gzserver with ability to load an SDF file or string

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 92a2891)

Co-authored-by: Addisu Z. Taddese <[email protected]>
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
* Add gzserver with ability to load an SDF file or string

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ROS node that runs Gazebo using gz::sim::Server
3 participants