Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executable name from gz_sim.launch.py #547

Closed
christophfroehlich opened this issue May 10, 2024 · 5 comments
Closed

executable name from gz_sim.launch.py #547

christophfroehlich opened this issue May 10, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@christophfroehlich
Copy link

How is this supposed to work with ruby?

if len(ign_version) or (ign_version == '' and int(gz_version) < 7):
exec = 'ruby $(which ign) gazebo'
if len(ign_version):
gz_version = ign_version
else:
exec = 'ruby $(which gz) sim'

The executable name just remains ruby $(which gz) sim, see for example the CI in gz_ros2_control. Is there something missing to be installed?

@christophfroehlich christophfroehlich added the bug Something isn't working label May 10, 2024
@mjcarroll
Copy link
Collaborator

I believe that it's just using simple shell expansion $() which gets evaluated before running ruby.

@christophfroehlich
Copy link
Author

Ok, so might it be that this an effect of launch.actions.ExecuteProcess, which creates a logger with a name being this command, but the command gets evaluated correctly when actually launching the executable?
At least, it does not make the log files very readable (neither in our CI, nor in log files posted e.g. on stack exchange)

@christophfroehlich
Copy link
Author

May I ask why there is a need for ruby at all?

@azeey
Copy link
Contributor

azeey commented May 14, 2024

#500 and related PRs should help with this since Gazebo will be ran as a ROS node.

May I ask why there is a need for ruby at all?

Ruby is needed because the gz is written in Ruby (https://github.com/gazebosim/gz-tools/blob/gz-tools2/src/gz.in). It's the tool that aggregates all of the commands available from all the Gazebo libraries. There's an effort to use binary executables (gazebosim/gz-tools#7) for this, but we have a ways to go.

@christophfroehlich
Copy link
Author

Ok, thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants