Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling #64

Merged
merged 41 commits into from
Nov 7, 2023
Merged

Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling #64

merged 41 commits into from
Nov 7, 2023

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Oct 6, 2023 •
edited
Loading

In this version, topics' QoS are configurable. The set of predefined topics' QoS takes precedence over the discovered topics' QoS.

The following features have also been implemented:

  • max-tx-rate (max transmission rate): the transmission frequency for sent samples.
  • max-rx-rate (max reception rate): the processing frequency for received samples.
  • downsampling: the proportion of samples to process for received samples.

These features can be configured generically, per participant, and per topic.

Merge after:

@Tempate Tempate mentioned this pull request Oct 6, 2023
Merged
@Tempate Tempate force-pushed the feature/manual_topics_conf branch 3 times, most recently from c8a91a8 to de90562 Compare October 11, 2023 10:37
@Tempate Tempate marked this pull request as ready for review October 13, 2023 06:16
@Tempate Tempate force-pushed the feature/manual_topics_conf branch 2 times, most recently from 583c80a to ae61ca4 Compare October 13, 2023 08:36
This was referenced Oct 16, 2023
Merged
Merged
@Tempate Tempate changed the title Manually fix a set of Topic QoS, and implement the max-rx-rate, max-tx-rate, and downsampling Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
@Tempate Tempate force-pushed the feature/manual_topics_conf branch 2 times, most recently from 4475790 to 741dd68 Compare October 17, 2023 07:07
jepemi
jepemi reviewed Oct 17, 2023
View reviewed changes
ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/core/DdsPipe.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/interface/IParticipant.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/types/dds/TopicQoS.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/DdsPipeConfiguration.hpp Outdated Show resolved Hide resolved
ddspipe_participants/include/ddspipe_participants/writer/auxiliar/BaseWriter.hpp Outdated Show resolved Hide resolved
ddspipe_participants/src/cpp/writer/auxiliar/BaseWriter.cpp Outdated Show resolved Hide resolved
ddspipe_core/test/unittest/core/ddspipe/DdsPipeTest.cpp Show resolved Hide resolved
ddspipe_yaml/src/cpp/YamlReader_types.cpp Show resolved Hide resolved
ddspipe_yaml/src/cpp/YamlReader_participants.cpp Outdated Show resolved Hide resolved
@jepemi
Copy link
Contributor

jepemi commented Oct 19, 2023 •
edited
Loading

YamlReader_types.cpp change to set_value()

jepemi
jepemi requested changes Oct 19, 2023
View reviewed changes
ddspipe_core/include/ddspipe_core/core/DdsPipe.hpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
jepemi
jepemi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jepemi
jepemi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanlofer-eprosima
juanlofer-eprosima requested changes Oct 27, 2023
View reviewed changes
ddspipe_yaml/include/ddspipe_yaml/yaml_configuration_tags.hpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/types/topic/filter/WildcardDdsFilterTopic.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/configuration/DdsPipeConfiguration.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/communication/dds/DdsBridge.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/communication/dds/DdsBridge.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/communication/dds/DdsBridge.hpp Show resolved Hide resolved
ddspipe_core/src/cpp/configuration/DdsPipeConfiguration.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/communication/dds/DdsBridge.cpp Outdated Show resolved Hide resolved
@Tempate
Fix compilation in Ubuntu 20.04 debug
61d1a46 
Signed-off-by: tempate <[email protected]>
@Tempate
Support manual topics in the dds participant
3b30130 
Signed-off-by: tempate <[email protected]>
@Tempate
Uncrustify
ad4a249 
Signed-off-by: tempate <[email protected]>
@Tempate
Minor fixes
6e3353e 
Signed-off-by: tempate <[email protected]>
@Tempate
Fix bug customizing a topic in the DdsBridge
fd7839f 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply suggestions
0bdb91f 
Signed-off-by: tempate <[email protected]>
@Tempate
Avoid using DdsTopics in the DdsBridge
aef399c 
Signed-off-by: tempate <[email protected]>
@Tempate
Minor fixes
55dc7bc 
Signed-off-by: tempate <[email protected]>
@Tempate
Add Topic QoS to the SchemaParticipant
44fa4c8 
Signed-off-by: tempate <[email protected]>
@Tempate
Bugfix copy method
268e148 
Signed-off-by: tempate <[email protected]>
@Tempate
Uncrustify & Windows fix
2f78320 
Signed-off-by: tempate <[email protected]>
@Tempate
Allowed topics test
24e5c49 
Signed-off-by: tempate <[email protected]>
@Tempate
Pack the QoSs in specs on a Topic QoS object
7fedb4a 
Signed-off-by: tempate <[email protected]>
@Tempate
Fix default Topic QoS variable
3e5a5e0 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply suggestions
f4ddf38 
Signed-off-by: tempate <[email protected]>
@Tempate
Rename max-depth to history-depth
ad29663 
Signed-off-by: tempate <[email protected]>
@Tempate
Uncrustify
9c64eda 
Signed-off-by: tempate <[email protected]>
@Tempate
Remove test that checks parsing QoS in a DdsTopic
ad75b36 
Signed-off-by: tempate <[email protected]>
@Tempate
Fix compilation in Ubuntu 20.04 debug
3d7e898 
Signed-off-by: tempate <[email protected]>
@Tempate
Improve test according to suggestion
c72b5ec 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply specs TopicQoS over discovery TopicQoS
ef730a7 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply suggestions
e13ca48 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply suggestions
1f9a662 
Signed-off-by: tempate <[email protected]>
@Tempate
Apply more suggestions
b9d2c47 
Signed-off-by: tempate <[email protected]>
juanlofer-eprosima
juanlofer-eprosima approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 600014d into main Nov 7, 2023
12 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/manual_topics_conf branch November 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

@jepemi jepemi jepemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tempate @jepemi @juanlofer-eprosima