Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix a set of Topic QoS, and implement the max-tx-rate #86

Merged
merged 23 commits into from
Nov 8, 2023

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Oct 16, 2023

In this version, topics' QoS are configurable. The set of predefined topics' QoS takes precedence over the discovered topics' QoS.

The transmission frequency for sent samples is now also configurable (max-tx-rate). It can be configured generically, per participant, and per topic.

Merge after:

Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In resources/configurations/recorder/complete_config.yaml and resources/configurations/replayer/complete_config.yaml include topics tags example

jepemi
jepemi previously approved these changes Oct 20, 2023
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all yaml files. There are builtin-topics containing qos tags.

docs/rst/recording/usage/configuration.rst Show resolved Hide resolved
docs/rst/recording/usage/configuration.rst Outdated Show resolved Hide resolved
docs/rst/recording/usage/configuration.rst Show resolved Hide resolved
docs/rst/recording/usage/configuration.rst Show resolved Hide resolved
docs/rst/recording/usage/configuration.rst Outdated Show resolved Hide resolved
docs/rst/replaying/usage/configuration.rst Show resolved Hide resolved
docs/rst/replaying/usage/configuration.rst Show resolved Hide resolved
docs/rst/replaying/usage/configuration.rst Outdated Show resolved Hide resolved
resources/configurations/replayer/complete_config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docs -> forthcoming_version.rst, update manual topics configuration description: Topics -> Manual Topics

docs/rst/recording/usage/configuration.rst Outdated Show resolved Hide resolved
docs/rst/replaying/usage/configuration.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builtin-topics no longer have meaning for DDS-Replayer

Signed-off-by: tempate <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Files Coverage Δ
ddsrecorder/src/cpp/tool/DdsRecorder.hpp 0.00% <ø> (ø)
...cipants/src/cpp/replayer/McapReaderParticipant.cpp 45.87% <100.00%> (+1.01%) ⬆️
ddsrecorder/src/cpp/main.cpp 0.00% <0.00%> (ø)
ddsreplayer/src/cpp/main.cpp 0.00% <0.00%> (ø)
ddsrecorder/src/cpp/tool/DdsRecorder.cpp 65.82% <25.00%> (-0.04%) ⬇️
ddsreplayer/src/cpp/tool/DdsReplayer.cpp 42.17% <42.85%> (+1.64%) ⬆️
..._yaml/src/cpp/replayer/YamlReaderConfiguration.cpp 20.38% <8.33%> (-0.20%) ⬇️
..._yaml/src/cpp/recorder/YamlReaderConfiguration.cpp 8.46% <7.69%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Signed-off-by: tempate <[email protected]>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 0d0c59a into main Nov 8, 2023
18 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/manual_topics_conf branch November 8, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants