Fix accommodation supplement rate & rebate when lodging #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
requested review from
Br3nda,
jduckles,
verbman,
asgharkazi,
MarkCalvert and
piacandrews
…red values not supplied result in warnings
verbman
reviewed
Dec 2, 2023
openfisca_aotearoa/variables/acts/social_security/accommodation_supplement/rate.py
Outdated
Show resolved
Hide resolved
openfisca_aotearoa/variables/acts/social_security/accommodation_supplement/rate.py
Outdated
Show resolved
Hide resolved
| Subpart 10 Accommodation Supplement - | ||
| 66 Social housing exclusion - | ||
| (1) Social housing exclusion - | ||
| (a) Rent | ||
| period: 2018-11-26 | ||
| input: | ||
| accommodation_type: |
There was a problem hiding this comment.
What is the purpose of under_the_sun? It's not a valid AccommodationType value, I note further in this file is under_the_moon. I'm not entirely sure why OpenFisca accepts this.
| (c) Residential care | ||
| Subpart 10 Accommodation Supplement - | ||
| 67 Other funding exclusion - | ||
| (c) Residential care | ||
| period: 2018-11-26 | ||
| input: | ||
| accommodation_type: | ||
| 2022-W01: [residential_care, under_the_moon] |
There was a problem hiding this comment.
What is the purpose of under_the_moon? It's not a valid AccommodationType value, note the other comment regarding under_the_sun. I'm not entirely sure why OpenFisca accepts this.
There was a problem hiding this comment.
Hey! Yes, these are arbitrary values.
… board_lodger_percent
verbman
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accommodation_supplementThese changes: