Merge pull request #58 from digitalaotearoa/acc-sup-fix-rate-et-rebate

Fix accommodation supplement rate & rebate when lodging
digitalaotearoa · Mar 13, 2024 · ce10a80 · ce10a80
2 parents 4e79032 + 75ce57e
commit ce10a80
Show file tree

Hide file tree

Showing 31 changed files with 447 additions and 279 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,32 @@
 # Changelog
 
+### 21.0.1 - [58](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/58)
+
+* Tax and benefit system evolution.
+* Impacted periods: all.
+* Impacted areas: 
+  - `variables/acts/social_security`
+  - `variables/acts/income_tax`
+  - `variables/regulation/student_allowance`
+  - `variables/regulation/social_security`
+  - `variables/demographics`
+  - `accommodation_supplement`
+* Details:
+  - Fix rate & rebate when accommodation type is lodging or boarding
+  - Normally, a %62 rate is to be applied in this particular case
+  - However, in reality %162 was being applied, which is incorrect
+  - Resolve warnings present in Accomodation Supplement Tests
+  - Resolved linting issues
+
+* Breaking changes:
+ - `student_allowance__married_or_partnered` period changed from month to day
+ - `student_allowance__supported_child` period changed from month to day
+ - `student_allowance__partner_has_a_supported_child` period changed from month to day
+ - `student_allowance__person_has_spouse` period changed from month to day, formula updated
+
+* Changes:
+ - `age_of_partner` set_input_dispatch_by_period applied
+
 ### 21.0.0 - [60](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/60)
 
 * Tax and benefit system evolution.
@@ -50,6 +77,7 @@
 Added new feature in folder `ōpenfisca_aotearoa/api_examples`. This is a space for example http calls to help illustrate how to call the API.
 Added example calls for entities, parameters, variables and then `acts/social_security/child_disability_allowance` as per project structure
 
+
 ### 20.1.1 - [48](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/48)
 
 * Test case.

diff --git a/...ca_aotearoa/parameters/social_security/accommodation_supplement/board_lodger_percent.yaml b/...ca_aotearoa/parameters/social_security/accommodation_supplement/board_lodger_percent.yaml
@@ -0,0 +1,5 @@
+description: 62% of the amount paid for board or lodging
+reference: https://www.legislation.govt.nz/act/public/2018/0032/latest/whole.html#LMS28903
+values:
+  2018-11-26:
+    value: 0.62
diff --git a/openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/_benefit_me.yaml b/openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/_benefit_me.yaml
@@ -8,6 +8,8 @@
       Peta:
         age:
           day:2022-01-01:365: 32
+        age_of_partner:
+          day:2022-01-01:365: 32
         social_security__residential_requirement:
           2022-W49: true
         social_security__in_a_relationship:
@@ -24,6 +26,8 @@
           2022-W49: rent
         accommodation_supplement__area_of_residence:
           2022-W49: area_2
+        student_allowance__person_has_spouse:
+          day:2022-12-01:31: false
   output:
     jobseeker_support__benefit:
       2022-W49: 440.96
@@ -43,6 +47,8 @@
       Peta:
         age:
           day:2022-01-01:365: 32
+        age_of_partner:
+          day:2022-01-01:365: 32
         social_security__residential_requirement:
           2022-W49: true
         social_security__in_a_relationship:
@@ -59,6 +65,8 @@
           2022-W49: rent
         accommodation_supplement__area_of_residence:
           2022-W49: area_2
+        student_allowance__person_has_spouse:
+          day:2022-12-01:31: false
       Anahera:
         family_tax_credit__dependent_child:
           2022: .5
@@ -81,6 +89,8 @@
       Kai:
         age:
           day:2022-01-01:365: 23
+        age_of_partner:
+          day:2022-01-01:365: 32
         accommodation_costs:
           week:2022-W01:52: 350
         accommodation_type:
@@ -89,6 +99,8 @@
           week:2022-W01:52: area_2
         accommodation_supplement__cash_assets:
           2022-W49: 800
+        student_allowance__person_has_spouse:
+          day:2022-12-01:31: false
   output:
     jobseeker_support__benefit:
       2022-W49: 0

diff --git a/...otearoa/tests/social_security/accommodation_supplement/2018/accommodation_supplement.yaml b/...otearoa/tests/social_security/accommodation_supplement/2018/accommodation_supplement.yaml
@@ -1,29 +1,33 @@
 - name: >
     Social Security Act 2018 -
-    § 10 Accommodation Supplement
+    Subpart 10 Accommodation Supplement
   period: 2018-11-26
   absolute_error_margin: 0.005
   input:
     accommodation_costs:
-      2022-W01: [20, 50, 100, 150, 150, 200]
-      2022-W02: [20, 50, 100, 150, 150, 200]
-      2023-W01: [20, 50, 100, 150, 150, 200]
-      2024-W01: [20, 50, 100, 150, 150, 200]
+      2022-W01: [50, 100, 150, 200, 300, 400]
+      2022-W02: [50, 100, 150, 200, 300, 400]
+      2023-W01: [50, 100, 150, 200, 300, 400]
+      2024-W01: [50, 100, 150, 200, 300, 400]
     accommodation_type:
-      2022-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
-      2022-W02: [lodging, lodging, lodging, lodging, lodging, lodging]
+      2022-W01: [rent, rent, rent, rent, rent, rent]
+      2022-W02: [board, board, board, board, board, board]
       2023-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
-      2024-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
+      2024-W01: [mortgage, mortgage, mortgage, mortgage, mortgage, mortgage]
     accommodation_supplement__cash_assets:
       2022-W01: [8100, 8100, 8100, 8100, 8101, 8100]
       2022-W02: [8100, 8100, 8100, 8100, 8101, 8100]
       2023-W01: [8100, 8100, 8100, 8100, 8101, 8100]
       2024-W01: [8100, 8100, 8100, 8100, 8101, 8100]
     age:
       day:2022-01-03:7: [24, 24, 24, 24, 24, 24]
-      day:2022-01-11:7: [24, 24, 24, 24, 24, 24]
-      day:2023-01-01:7: [24, 24, 24, 24, 24, 24]
+      day:2022-01-10:7: [24, 24, 24, 24, 24, 24]
+      day:2023-01-02:7: [24, 24, 24, 24, 24, 24]
       day:2024-01-01:7: [24, 24, 24, 24, 24, 24]
+    age_of_partner:
+      day:2022-01-01:31: [24, 24, 24, 24, 24, 24]
+      day:2023-01-01:31: [24, 24, 24, 24, 24, 24]
+      day:2024-01-01:31: [24, 24, 24, 24, 24, 24]
     jobseeker_support__receiving:
       2022-W01: [true, true, true, true, true, true]
       2022-W02: [true, true, true, true, true, true]
@@ -39,9 +43,13 @@
       2022-W02: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
       2023-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
       2024-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
+    basic_grant__entitled:
+      2022-01: [false, false, false, false, false, false]
+      2023-01: [false, false, false, false, false, false]
+      2024-01: [false, false, false, false, false, false]
   output:
     accommodation_supplement:
-      2022-W01: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # January
-      2022-W02: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # February (the same)
-      2023-W01: [0.00, 1.57, 58.28, 114.98, 0.00, 165.00] # January a year later
-      2024-W01: [0.00, 0.00, 54.30, 111.00, 0.00, 165.00] # January, another a year later
+      2022-W01: [0.00, 21.26, 56.26, 91.26, 0.00, 165.00] # January
+      2022-W02: [0.00, 0.00, 16.36, 38.06, 0.00, 124.86] # February (the same)
+      2023-W01: [0.00, 0.00, 9.97, 31.68, 0.00, 118.48] # January a year later
+      2024-W01: [0.00, 0.00, 34.07, 69.07, 0.00, 165.00] # January, another a year later
diff --git a/openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/assets.yaml b/openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/assets.yaml
@@ -1,6 +1,7 @@
 - name: >
     Social Security Regulations 2018 -
-    5   Accommodation Supplement -
+    Part 2 Assistance -
+    Subpart 5 Accommodation Supplement -
     15  Assets requirement -
     (1) The assets requirement, for the purposes of section 65(1)(b) of the
         Act, is that a person’s cash assets must not exceed—
@@ -47,7 +48,8 @@
 
 - name: >
     Social Security Regulations 2018 -
-    5   Accommodation Supplement -
+    Part 2 Assistance -
+    Subpart 5 Accommodation Supplement -
     15  Assets requirement -
     (1) The assets requirement, for the purposes of section 65(1)(b) of the
         Act, is that a person’s cash assets must not exceed—
@@ -93,7 +95,8 @@
 
 - name: >
     Social Security Regulations 2018 -
-    5   Accommodation Supplement -
+    Part 2 Assistance -
+    Subpart 5 Accommodation Supplement -
     15  Assets requirement -
     (1) The assets requirement, for the purposes of section 65(1)(b) of the
         Act, is that a person’s cash assets must not exceed—
@@ -139,7 +142,8 @@
 
 - name: >
     Social Security Regulations 2018 -
-    5   Accommodation Supplement -
+    Part 2 Assistance -
+    Subpart 5 Accommodation Supplement -
     15  Assets requirement -
     (1) The assets requirement, for the purposes of section 65(1)(b) of the
         Act, is that a person’s cash assets must not exceed—