Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accommodation supplement rate & rebate when lodging #58

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Fix accommodation supplement rate & rebate when lodging #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6f12671
Consolidate tests
bonjourmauko Sep 27, 2023
1bc12d0
Fix rate & rebate calculation
bonjourmauko Sep 27, 2023
d34100b
Bump version
bonjourmauko Sep 27, 2023
b271c89
Resolves multiple warnings when running test suites, apparently requi…
verbman Dec 2, 2023
f2ac7ea
Fixes warnings and linting issues related to the accomodation supplement
verbman Mar 12, 2024
d02425d
Consolidate tests
bonjourmauko Sep 27, 2023
33d5663
Fix rate & rebate calculation
bonjourmauko Sep 27, 2023
3b9109c
add boarding to the accommodation_supplement__rate with new parameter…
verbman Mar 13, 2024
613b98c
Merge in changes to accomodation supplement rate
verbman Mar 13, 2024
517ea40
merge warnings and linting issues from seperate branch
verbman Mar 13, 2024
75ce57e
Merge branch 'main' into acc-sup-fix-rate-et-rebate
verbman Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
# Changelog

### 21.0.1 - [58](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/58)

* Tax and benefit system evolution.
* Impacted periods: all.
* Impacted areas:
- `variables/acts/social_security`
- `variables/acts/income_tax`
- `variables/regulation/student_allowance`
- `variables/regulation/social_security`
- `variables/demographics`
- `accommodation_supplement`
* Details:
- Fix rate & rebate when accommodation type is lodging or boarding
- Normally, a %62 rate is to be applied in this particular case
- However, in reality %162 was being applied, which is incorrect
- Resolve warnings present in Accomodation Supplement Tests
- Resolved linting issues

* Breaking changes:
- `student_allowance__married_or_partnered` period changed from month to day
- `student_allowance__supported_child` period changed from month to day
- `student_allowance__partner_has_a_supported_child` period changed from month to day
- `student_allowance__person_has_spouse` period changed from month to day, formula updated

* Changes:
- `age_of_partner` set_input_dispatch_by_period applied

### 21.0.0 - [60](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/60)

* Tax and benefit system evolution.
Expand Down Expand Up @@ -50,6 +77,7 @@
Added new feature in folder `ōpenfisca_aotearoa/api_examples`. This is a space for example http calls to help illustrate how to call the API.
Added example calls for entities, parameters, variables and then `acts/social_security/child_disability_allowance` as per project structure


### 20.1.1 - [48](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/48)

* Test case.
Expand Down
5 changes: 5 additions & 0 deletions ...ca_aotearoa/parameters/social_security/accommodation_supplement/board_lodger_percent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
description: 62% of the amount paid for board or lodging
reference: https://www.legislation.govt.nz/act/public/2018/0032/latest/whole.html#LMS28903
values:
2018-11-26:
value: 0.62
12 changes: 12 additions & 0 deletions openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/_benefit_me.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
Peta:
age:
day:2022-01-01:365: 32
age_of_partner:
day:2022-01-01:365: 32
social_security__residential_requirement:
2022-W49: true
social_security__in_a_relationship:
Expand All @@ -24,6 +26,8 @@
2022-W49: rent
accommodation_supplement__area_of_residence:
2022-W49: area_2
student_allowance__person_has_spouse:
day:2022-12-01:31: false
output:
jobseeker_support__benefit:
2022-W49: 440.96
Expand All @@ -43,6 +47,8 @@
Peta:
age:
day:2022-01-01:365: 32
age_of_partner:
day:2022-01-01:365: 32
social_security__residential_requirement:
2022-W49: true
social_security__in_a_relationship:
Expand All @@ -59,6 +65,8 @@
2022-W49: rent
accommodation_supplement__area_of_residence:
2022-W49: area_2
student_allowance__person_has_spouse:
day:2022-12-01:31: false
Anahera:
family_tax_credit__dependent_child:
2022: .5
Expand All @@ -81,6 +89,8 @@
Kai:
age:
day:2022-01-01:365: 23
age_of_partner:
day:2022-01-01:365: 32
accommodation_costs:
week:2022-W01:52: 350
accommodation_type:
Expand All @@ -89,6 +99,8 @@
week:2022-W01:52: area_2
accommodation_supplement__cash_assets:
2022-W49: 800
student_allowance__person_has_spouse:
day:2022-12-01:31: false
output:
jobseeker_support__benefit:
2022-W49: 0
Expand Down
36 changes: 22 additions & 14 deletions ...otearoa/tests/social_security/accommodation_supplement/2018/accommodation_supplement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,33 @@
- name: >
Social Security Act 2018 -
§ 10 Accommodation Supplement
Subpart 10 Accommodation Supplement
period: 2018-11-26
absolute_error_margin: 0.005
input:
accommodation_costs:
2022-W01: [20, 50, 100, 150, 150, 200]
2022-W02: [20, 50, 100, 150, 150, 200]
2023-W01: [20, 50, 100, 150, 150, 200]
2024-W01: [20, 50, 100, 150, 150, 200]
2022-W01: [50, 100, 150, 200, 300, 400]
2022-W02: [50, 100, 150, 200, 300, 400]
2023-W01: [50, 100, 150, 200, 300, 400]
2024-W01: [50, 100, 150, 200, 300, 400]
accommodation_type:
2022-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2022-W02: [lodging, lodging, lodging, lodging, lodging, lodging]
2022-W01: [rent, rent, rent, rent, rent, rent]
2022-W02: [board, board, board, board, board, board]
2023-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2024-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2024-W01: [mortgage, mortgage, mortgage, mortgage, mortgage, mortgage]
accommodation_supplement__cash_assets:
2022-W01: [8100, 8100, 8100, 8100, 8101, 8100]
2022-W02: [8100, 8100, 8100, 8100, 8101, 8100]
2023-W01: [8100, 8100, 8100, 8100, 8101, 8100]
2024-W01: [8100, 8100, 8100, 8100, 8101, 8100]
age:
day:2022-01-03:7: [24, 24, 24, 24, 24, 24]
day:2022-01-11:7: [24, 24, 24, 24, 24, 24]
day:2023-01-01:7: [24, 24, 24, 24, 24, 24]
day:2022-01-10:7: [24, 24, 24, 24, 24, 24]
day:2023-01-02:7: [24, 24, 24, 24, 24, 24]
day:2024-01-01:7: [24, 24, 24, 24, 24, 24]
age_of_partner:
day:2022-01-01:31: [24, 24, 24, 24, 24, 24]
day:2023-01-01:31: [24, 24, 24, 24, 24, 24]
day:2024-01-01:31: [24, 24, 24, 24, 24, 24]
jobseeker_support__receiving:
2022-W01: [true, true, true, true, true, true]
2022-W02: [true, true, true, true, true, true]
Expand All @@ -39,9 +43,13 @@
2022-W02: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
2023-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
2024-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
basic_grant__entitled:
2022-01: [false, false, false, false, false, false]
2023-01: [false, false, false, false, false, false]
2024-01: [false, false, false, false, false, false]
output:
accommodation_supplement:
2022-W01: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # January
2022-W02: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # February (the same)
2023-W01: [0.00, 1.57, 58.28, 114.98, 0.00, 165.00] # January a year later
2024-W01: [0.00, 0.00, 54.30, 111.00, 0.00, 165.00] # January, another a year later
2022-W01: [0.00, 21.26, 56.26, 91.26, 0.00, 165.00] # January
2022-W02: [0.00, 0.00, 16.36, 38.06, 0.00, 124.86] # February (the same)
2023-W01: [0.00, 0.00, 9.97, 31.68, 0.00, 118.48] # January a year later
2024-W01: [0.00, 0.00, 34.07, 69.07, 0.00, 165.00] # January, another a year later
12 changes: 8 additions & 4 deletions openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/assets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -47,7 +48,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -93,7 +95,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -139,7 +142,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down
Loading
Loading