Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accommodation supplement rate & rebate when lodging #58

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Fix accommodation supplement rate & rebate when lodging #58

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6f12671
Consolidate tests
bonjourmauko Sep 27, 2023
1bc12d0
Fix rate & rebate calculation
bonjourmauko Sep 27, 2023
d34100b
Bump version
bonjourmauko Sep 27, 2023
b271c89
Resolves multiple warnings when running test suites, apparently requi…
verbman Dec 2, 2023
f2ac7ea
Fixes warnings and linting issues related to the accomodation supplement
verbman Mar 12, 2024
d02425d
Consolidate tests
bonjourmauko Sep 27, 2023
33d5663
Fix rate & rebate calculation
bonjourmauko Sep 27, 2023
3b9109c
add boarding to the accommodation_supplement__rate with new parameter…
verbman Mar 13, 2024
613b98c
Merge in changes to accomodation supplement rate
verbman Mar 13, 2024
517ea40
merge warnings and linting issues from seperate branch
verbman Mar 13, 2024
75ce57e
Merge branch 'main' into acc-sup-fix-rate-et-rebate
verbman Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

### 20.1.2 - [58](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/58)

* Tax and benefit system evolution.
* Impacted periods: from 26/11/2018.
* Impacted areas: `accommodation_supplement`
* Details:
- Fix rate & rebate when accommodation type is lodging
- Normally, a %62 rate is to be applied in this particular case
- However, in reality %162 was being applied, which is incorrect

### 20.1.1 - [48](https://github.com/digitalaotearoa/openfisca-aotearoa/pull/48)

* Test case.
Expand Down
6 changes: 6 additions & 0 deletions openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/_benefit_me.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
2022-W49: rent
accommodation_supplement__area_of_residence:
2022-W49: area_2
student_allowance__person_has_spouse:
2022-12: false
output:
jobseeker_support__benefit:
2022-W49: 440.96
Expand Down Expand Up @@ -59,6 +61,8 @@
2022-W49: rent
accommodation_supplement__area_of_residence:
2022-W49: area_2
student_allowance__person_has_spouse:
2022-12: false
Anahera:
family_tax_credit__dependent_child:
2022: .5
Expand Down Expand Up @@ -89,6 +93,8 @@
week:2022-W01:52: area_2
accommodation_supplement__cash_assets:
2022-W49: 800
student_allowance__person_has_spouse:
2022-12: false
output:
jobseeker_support__benefit:
2022-W49: 0
Expand Down
32 changes: 18 additions & 14 deletions ...otearoa/tests/social_security/accommodation_supplement/2018/accommodation_supplement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
- name: >
Social Security Act 2018 -
§ 10 Accommodation Supplement
Subpart 10 Accommodation Supplement
period: 2018-11-26
absolute_error_margin: 0.005
input:
accommodation_costs:
2022-W01: [20, 50, 100, 150, 150, 200]
2022-W02: [20, 50, 100, 150, 150, 200]
2023-W01: [20, 50, 100, 150, 150, 200]
2024-W01: [20, 50, 100, 150, 150, 200]
2022-W01: [50, 100, 150, 200, 300, 400]
2022-W02: [50, 100, 150, 200, 300, 400]
2023-W01: [50, 100, 150, 200, 300, 400]
2024-W01: [50, 100, 150, 200, 300, 400]
accommodation_type:
2022-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2022-W02: [lodging, lodging, lodging, lodging, lodging, lodging]
2022-W01: [rent, rent, rent, rent, rent, rent]
2022-W02: [board, board, board, board, board, board]
2023-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2024-W01: [lodging, lodging, lodging, lodging, lodging, lodging]
2024-W01: [mortgage, mortgage, mortgage, mortgage, mortgage, mortgage]
accommodation_supplement__cash_assets:
2022-W01: [8100, 8100, 8100, 8100, 8101, 8100]
2022-W02: [8100, 8100, 8100, 8100, 8101, 8100]
2023-W01: [8100, 8100, 8100, 8100, 8101, 8100]
2024-W01: [8100, 8100, 8100, 8100, 8101, 8100]
age:
day:2022-01-03:7: [24, 24, 24, 24, 24, 24]
day:2022-01-11:7: [24, 24, 24, 24, 24, 24]
day:2023-01-01:7: [24, 24, 24, 24, 24, 24]
day:2022-01-10:7: [24, 24, 24, 24, 24, 24]
day:2023-01-02:7: [24, 24, 24, 24, 24, 24]
day:2024-01-01:7: [24, 24, 24, 24, 24, 24]
jobseeker_support__receiving:
2022-W01: [true, true, true, true, true, true]
Expand All @@ -39,9 +39,13 @@
2022-W02: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
2023-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
2024-W01: [Alexandra urban area, Alexandra urban area, Alexandra urban area, Arrowtown urban area, Arrowtown urban area, Arrowtown urban area]
basic_grant__entitled:
2022-01: [false, false, false, false, false, false]
2023-01: [false, false, false, false, false, false]
2024-01: [false, false, false, false, false, false]
output:
accommodation_supplement:
2022-W01: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # January
2022-W02: [0.00, 7.96, 64.66, 121.36, 0.00, 165.00] # February (the same)
2023-W01: [0.00, 1.57, 58.28, 114.98, 0.00, 165.00] # January a year later
2024-W01: [0.00, 0.00, 54.30, 111.00, 0.00, 165.00] # January, another a year later
2022-W01: [0.00, 21.26, 56.26, 91.26, 0.00, 165.00] # January
2022-W02: [0.00, 21.26, 56.26, 91.26, 0.00, 165.00] # February (the same)
2023-W01: [0.00, 0.00, 9.97, 31.68, 0.00, 118.48] # January a year later
2024-W01: [0.00, 0.00, 34.07, 69.07, 0.00, 165.00] # January, another a year later
12 changes: 8 additions & 4 deletions openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/assets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -47,7 +48,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -93,7 +95,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down Expand Up @@ -139,7 +142,8 @@

- name: >
Social Security Regulations 2018 -
5 Accommodation Supplement -
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
15 Assets requirement -
(1) The assets requirement, for the purposes of section 65(1)(b) of the
Act, is that a person’s cash assets must not exceed—
Expand Down
181 changes: 104 additions & 77 deletions openfisca_aotearoa/tests/social_security/accommodation_supplement/2018/base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Beneficiaries who are single -
(a) for a single beneficiary under the age of 25 years, the maximum weekly
rate of a benefit that the beneficiary would have been entitled to
receive, before any abatement or deduction, if the beneficiary had
attained the age of 25 years: [...]
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Beneficiaries who are single -
(a) for a single beneficiary under the age of 25 years, the maximum
weekly rate of a benefit that the beneficiary would have been
entitled to receive, before any abatement or deduction, if the
beneficiary had attained the age of 25 years: [...]
period: 2018-11-26
input:
age:
Expand All @@ -19,16 +21,18 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Beneficiaries who are single -
(b) for a single beneficiary with 1 or more dependent children,—
(i) the maximum weekly rate of a benefit that the beneficiary is
entitled to receive, before any abatement or deduction; plus
(ii) the maximum annual rate of family tax credit (divided by 52) that
is payable in respect of an eldest dependent child who is under
16 years old under subparts MA to MF and MZ of the Income Tax Act
2007:
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Beneficiaries who are single -
(b) for a single beneficiary with 1 or more dependent children,—
(i) the maximum weekly rate of a benefit that the beneficiary is
entitled to receive, before any abatement or deduction; plus
(ii) the maximum annual rate of family tax credit (divided by 52)
that is payable in respect of an eldest dependent child who
is under 16 years old under subparts MA to MF and MZ of the
Income Tax Act 2007:
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand Down Expand Up @@ -81,12 +85,14 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Beneficiaries who are single -
(c) for any other single beneficiary, the maximum weekly rate of a
benefit that the beneficiary would be entitled to receive before
any abatement or deduction:
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Beneficiaries who are single -
(c) for any other single beneficiary, the maximum weekly rate of a
benefit that the beneficiary would be entitled to receive before
any abatement or deduction:
period: 2018-11-26
input:
age:
Expand All @@ -100,13 +106,15 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Beneficiaries who are in a relationship -
(c) for a beneficiary who is in a relationship and is not a beneficiary to
whom paragraph (e) applies,—
(i) the maximum weekly rate of a benefit that the beneficiary
is entitled to receive, before any abatement or deduction; [...]
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Beneficiaries who are in a relationship -
(c) for a beneficiary who is in a relationship and is not a beneficiary
to whom paragraph (e) applies,—
(i) the maximum weekly rate of a benefit that the beneficiary
is entitled to receive, before any abatement or deduction;
period: 2018-11-26
input:
jobseeker_support__receiving:
Expand All @@ -120,15 +128,18 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Beneficiaries who are in a relationship -
(c) for a beneficiary who is in a relationship and is not a beneficiary to
whom paragraph (e) applies,— [...]
(ii) if the beneficiary has 1 or more dependent children, the maximum
annual rate of family tax credit (divided by 52) that is paid in
respect of an eldest dependent child who is under 16 years (if
any) under subparts MA to MF and MZ of the Income Tax Act 2007;
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Beneficiaries who are in a relationship -
(c) for a beneficiary who is in a relationship and is not a beneficiary
to whom paragraph (e) applies,— [...]
(ii) if the beneficiary has 1 or more dependent children, the
maximum annual rate of family tax credit (divided by 52) that
is paid in respect of an eldest dependent child who is under
16 years (if any) under subparts MA to MF and MZ of the
Income Tax Act 2007;
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand Down Expand Up @@ -185,14 +196,18 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Non-beneficiaries who are single -
(f) for a single non-beneficiary with 1 or more dependent children,—
(i) the appropriate maximum weekly rate of jobseeker support; plus
(ii) the annual rate of family tax credit (divided by 52) that is
payable in respect of an eldest dependent child who is under 16
years under subparts MA to MF and MZ of the Income Tax Act 2007:
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Non-beneficiaries who are single -
(f) for a single non-beneficiary with 1 or more dependent children,—
(i) the appropriate maximum weekly rate of jobseeker support;
plus
(ii) the annual rate of family tax credit (divided by 52) that is
payable in respect of an eldest dependent child who is under
16 years under subparts MA to MF and MZ of the Income Tax Act
2007:
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand Down Expand Up @@ -245,12 +260,14 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Non-beneficiaries who are single -
(g) for any other single non-beneficiary, the weekly rate of jobseeker
support at the rate in clause 1(d) of Part 1 of Schedule 4 of the Act
before any abatement or deduction:
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Non-beneficiaries who are single -
(g) for any other single non-beneficiary, the weekly rate of jobseeker
support at the rate in clause 1(d) of Part 1 of Schedule 4 of the
Act before any abatement or deduction:
period: 2018-11-26
input:
jobseeker_support__entitled:
Expand All @@ -262,11 +279,13 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,—
(i) the appropriate maximum weekly rate of jobseeker support; plus
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,—
(i) the appropriate maximum weekly rate of jobseeker support;
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand All @@ -281,14 +300,17 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,— [...]
(ii) if the beneficiary has 1 or more dependent children, the maximum
annual rate of family tax credit (divided by 52) that is payable
in respect of an eldest dependent child who is under 16 years
under subparts MA to MF and MZ of the Income Tax Act 2007; plus
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,— [...]
(ii) if the beneficiary has 1 or more dependent children, the
maximum annual rate of family tax credit (divided by 52) that
is payable in respect of an eldest dependent child who is
under 16 years under subparts MA to MF and MZ of the Income
Tax Act 2007;
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand Down Expand Up @@ -345,17 +367,22 @@

- name: >
Social Security Regulations 2018 -
Accommodation Supplement -
Base rate -
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,—
(i) the appropriate maximum weekly rate of jobseeker support; plus
(ii) if the beneficiary has 1 or more dependent children, the maximum
annual rate of family tax credit (divided by 52) that is payable
in respect of an eldest dependent child who is under 16 years
under subparts MA to MF and MZ of the Income Tax Act 2007; plus
(iii) the maximum weekly rate of jobseeker support that would have been
payable in respect of the beneficiary’s spouse or partner.
Part 2 Assistance -
Subpart 5 Accommodation Supplement -
17 Base rate -
(2) The base rate is as follows:
Non-beneficiaries who are in a relationship -
(h) for a non-beneficiary who is in a relationship,—
(i) the appropriate maximum weekly rate of jobseeker support;
plus
(ii) if the beneficiary has 1 or more dependent children, the
maximum annual rate of family tax credit (divided by 52) that
is payable in respect of an eldest dependent child who is
under 16 years under subparts MA to MF and MZ of the Income
Tax Act 2007; plus
(iii) the maximum weekly rate of jobseeker support that would have
been payable in respect of the beneficiary’s spouse or
partner.
period: 2018-11-26
absolute_error_margin: 0.005
input:
Expand Down
Loading