refactor(behavior_path_avoidance_by_lane_change_module): prefix package and namespace with autoware_ #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
requested review from
rej55,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
esteve
added
the
tag:run-build-and-test-differential
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
43d5b57
to
4711115
Compare
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
b099494
to
3213947
Compare
|
@xmfcx @mitsudome-r @rej55 @satoshi-ota @shmpwk @TomohitoAndo @tkimura4 @zulfaqar-azmi-t4 This is now ready for review, please have a look at it when you have a moment. Thanks. |
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
fcf0ff7
to
7398ba5
Compare
|
I've reverted any performance or any other improvements detected by clang-tidy, the CI will now fail because of the clang-tidy check, but now the PR only conntains the prefix changes. |
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
bfd968e
to
cabcb1a
Compare
auto-merge was automatically disabled
May 7, 2024 12:47
Pull request was converted to draft
|
Back to draft because I'm going to rename folders and move headers to a separate folder (see autowarefoundation/autoware#4569 (comment)) |
github-actions
bot
added
type:documentation
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
3ae34b6
to
bde2856
Compare
|
@xmfcx this PR is ready for review again. |
xmfcx
added
the
tag:deploy-docs
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
ef83960
to
9a94bd0
Compare
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
163b5b8
to
6a14bee
Compare
auto-merge was automatically disabled
May 23, 2024 15:08
Pull request was converted to draft
xmfcx
changed the title
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
6a14bee
to
9665d4d
Compare
|
@xmfcx I've fixed the build issues in this PR, could you have a look at it when you have a moment? Thanks. |
esteve
changed the title
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
7 times, most recently
from
ee8389b
to
37ea393
Compare
4 tasks
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
2 times, most recently
from
47ead0e
to
6d3194b
Compare
|
@satoshi-ota done, I've fixed all the build issues. I've also moved the header to src so they are not exported (there are no downstream packages that depend on this package), and put all the code in the |
…and namespace with autoware_ Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
prefix-behavior_path_avoidance_by_lane_change_module
branch
from
721db1b
to
93e4c6f
Compare
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…age and namespace with autoware_ (#6638) * build(behavior_path_avoidance_by_lane_change_module): prefix package and namespace with autoware_ Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_behavior_path_avoidance_by_lane_change_module): fix namespaces Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_behavior_path_avoidance_by_lane_change_module): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_behavior_path_avoidance_by_lane_change_module): fix tests Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_behavior_path_avoidance_by_lane_change_module): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_behavior_path_avoidance_by_lane_change_module): revert clang-tidy fixes for naming functions Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_behavior_path_avoidance_by_lane_change_module): revert clang-tidy fixes for naming functions Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_behavior_path_external_request_lane_change_module): revert performance-related clang-tidy fixes Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_behavior_path_avoidance_by_lane_change_module): revert clang-tidy fixes for naming functions Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_behavior_path_avoidance_by_lane_change_module): update CODEOWNERS and .pages files Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_behavior_path_avoidance_by_lane_change_module): move headers files to src Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_behavior_path_avoidance_by_lane_change_module): fix include paths Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * Update planning/autoware_behavior_path_avoidance_by_lane_change_module/src/scene.cpp Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build: fix missing using clauses Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
autoware_prefix to the package and puts headers in theautowarenamespace.Part of:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.