Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: upload test artifacts along with reports #35479

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Feb 21, 2024

What

This PR suggests a more generic approach than #35317 at uploading test artifacts with reports.

  • Introduce a Artifact dataclass
  • Add a artifacts attribute to Result
  • Save artifacts locally and to GCS on report.save()

Report example here

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 4:36am

Copy link
Contributor Author

alafanechere commented Feb 21, 2024

@alafanechere alafanechere force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch 4 times, most recently from 44dbc73 to 6e5b20f Compare February 21, 2024 14:16
@alafanechere alafanechere marked this pull request as ready for review February 21, 2024 14:23
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 21, 2024 14:24
@alafanechere alafanechere force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch from b8938d7 to 831c313 Compare February 21, 2024 14:43
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs branch from fd62631 to 8cc1863 Compare February 21, 2024 21:02
@stephane-airbyte stephane-airbyte force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch from efc35d8 to e891176 Compare February 21, 2024 21:02
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs branch from 8cc1863 to af54bd4 Compare February 22, 2024 00:29
@stephane-airbyte stephane-airbyte force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch from e891176 to 60f1613 Compare February 22, 2024 00:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs branch from af54bd4 to 9515739 Compare February 22, 2024 00:34
@stephane-airbyte stephane-airbyte force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch from 60f1613 to 3d521a4 Compare February 22, 2024 00:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs branch from 9515739 to 2e118bf Compare February 22, 2024 04:36
@stephane-airbyte stephane-airbyte force-pushed the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch from 3d521a4 to 823b5c4 Compare February 22, 2024 04:36
@stephane-airbyte stephane-airbyte merged commit 823b5c4 into stephane/02-13-make_airbyte-ci_pass_a_parameter_to_the_java_connectors_to_the_location_of_the_logs Feb 22, 2024
25 of 32 checks passed
@stephane-airbyte stephane-airbyte deleted the augustin/02-21-airbyte-ci_upload_test_artifacts_along_with_reports branch February 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants