fix tests (for real?) #35608
Merged
fix tests (for real?) #35608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
This was referenced Feb 24, 2024
This was referenced Feb 24, 2024
Closed
Closed
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
413ee51
to
4e17098
Compare
stephane-airbyte
changed the base branch from
stephane/02-23-disable_source-mssql_tests_that_are_failing_on_localhost
to
stephane/02-21-improve_logging_in_MsSQLTestDatabase
stephane-airbyte
force-pushed
the
stephane/02-21-improve_logging_in_MsSQLTestDatabase
branch
from
5dd97b2
to
d21b594
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
4e17098
to
4b61b14
Compare
stephane-airbyte
changed the base branch from
stephane/02-21-improve_logging_in_MsSQLTestDatabase
to
stephane/02-09-try_removing_concurrency_for_source-mssql_tests
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
8 times, most recently
from
ed55ae1
to
05c3750
Compare
stephane-airbyte
force-pushed
the
stephane/02-21-move_some_very_verbose_log_messages_to_info
branch
from
f390b9e
to
942a0f2
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
2 times, most recently
from
64068bd
to
80a5729
Compare
stephane-airbyte
changed the base branch from
stephane/02-21-move_some_very_verbose_log_messages_to_info
to
stephane/02-24-move_source-mssql_to_latest_CDK
stephane-airbyte
force-pushed
the
stephane/02-24-move_source-mssql_to_latest_CDK
branch
3 times, most recently
from
e45df64
to
029a4d3
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
80a5729
to
ab212b9
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-move_source-mssql_to_latest_CDK
branch
2 times, most recently
from
bbe3176
to
0f65fb8
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
ab212b9
to
98854db
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-move_source-mssql_to_latest_CDK
branch
from
0f65fb8
to
dd7b58e
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
98854db
to
9461a4c
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-move_source-mssql_to_latest_CDK
branch
from
dd7b58e
to
90275fb
Compare
stephane-airbyte
force-pushed
the
stephane/02-24-fix_tests_for_real_
branch
from
9461a4c
to
ce3d6be
Compare
stephane-airbyte
merged commit ce3d6be
into
stephane/02-24-move_source-mssql_to_latest_CDK
24 of 38 checks passed
This was referenced Feb 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're disabling some tests that are failing or hanging both on CI and on localhost: SshPasswordMssqlSourceAcceptanceTest, SshKeyMssqlSourceAcceptanceTest and part of AbstractMssqlSourceDatatypeTest. Hopefully we'll fix and reenable them in a subsequent change
Some tests were failing because of a timing issue. For those, we do a few things:
In the process of doing that, there's an edge case that was found in MsssqlCdcTargetPosition where the MinLsn could be null if there hasn't been any changes to the source DB since CDC was enabled. It's a rare case, but not one that should cause a sync failure.
Finally, even with the changes above, some tests are still failing on CI. We're disabling those as well, with the goal of really fixing them soon: