Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try removing concurrency for source-mssql tests #35125

Closed
wants to merge 8 commits into from
Closed

try removing concurrency for source-mssql tests #35125

wants to merge 8 commits into from

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 5:26pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 10, 2024
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Feb 10, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from 3bf1d32 to 3e033b7 Compare February 10, 2024 07:59
@stephane-airbyte stephane-airbyte changed the base branch from stephane/02-09-use_lists_instead_of_streams_in_TestDatabase to stephane/02-09-fix_msssql_tests_take_3 February 10, 2024 07:59
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 5e4fb75 to e9cd6b4 Compare February 10, 2024 08:00
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 10, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 2 times, most recently from 979417b to d731848 Compare February 10, 2024 09:10
This was referenced Feb 10, 2024
Closed
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d731848 to 84bf501 Compare February 13, 2024 19:20
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 13, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 2 times, most recently from 4317dea to 3f48107 Compare February 16, 2024 00:44
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 16, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 2 times, most recently from 2f31ce7 to 6393401 Compare February 16, 2024 00:59
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from 3e033b7 to 82419cd Compare February 16, 2024 00:59
@octavia-squidington-iii octavia-squidington-iii removed CDK Connector Development Kit area/connectors Connector related issues labels Feb 16, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 6393401 to 6e5f022 Compare February 16, 2024 01:02
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from 82419cd to 9f064b2 Compare February 16, 2024 01:02
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 16, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 6e5f022 to d9affb7 Compare February 16, 2024 01:06
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from f85ed94 to 24cc714 Compare February 23, 2024 22:55
This was referenced Feb 24, 2024
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d260b19 to a07e478 Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from 24cc714 to 420f379 Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 24, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from a07e478 to 7bf7979 Compare February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from 420f379 to e8ddd64 Compare February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 7bf7979 to 2503621 Compare February 24, 2024 09:18
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from e8ddd64 to b8c0b32 Compare February 24, 2024 09:19
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-try_removing_concurrency_for_source-mssql_tests branch from b8c0b32 to 885693d Compare February 24, 2024 17:26
@stephane-airbyte stephane-airbyte changed the base branch from stephane/02-09-fix_msssql_tests_take_3 to stephane/02-21-move_some_very_verbose_log_messages_to_info February 24, 2024 17:26
This was referenced Feb 24, 2024
Merged
Closed
Closed
Closed
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-move_some_very_verbose_log_messages_to_info branch from 2b92c25 to f390b9e Compare February 25, 2024 02:40
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 25, 2024
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-move_some_very_verbose_log_messages_to_info branch from f390b9e to 942a0f2 Compare February 26, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephane-airbyte @octavia-squidington-iii