Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more. attempts at fixing tests #35395

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 9:20am

Copy link
Contributor Author

stephane-airbyte commented Feb 18, 2024

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-add_proper_logging_to_junit_runs branch from c02943b to ddea01a Compare February 18, 2024 02:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 28638c5 to d0b2110 Compare February 18, 2024 02:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-add_proper_logging_to_junit_runs branch from ddea01a to 6a9ee8b Compare February 18, 2024 17:31
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from d0b2110 to 78b67f0 Compare February 18, 2024 17:31
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-add_proper_logging_to_junit_runs branch from 6a9ee8b to aff4e0d Compare February 18, 2024 18:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch 2 times, most recently from 825bba9 to 9a84e53 Compare February 18, 2024 18:17
@octavia-squidington-iii octavia-squidington-iii added CDK Connector Development Kit labels Feb 18, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 9a84e53 to e714158 Compare February 19, 2024 16:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-add_proper_logging_to_junit_runs branch from aff4e0d to d36cd75 Compare February 19, 2024 17:33
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from e714158 to 0fde2fa Compare February 19, 2024 17:33
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Feb 19, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-add_proper_logging_to_junit_runs branch from d36cd75 to 4bac69c Compare February 19, 2024 18:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 9794410 to cc8affd Compare February 22, 2024 05:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 9b7a83c to 5aec170 Compare February 22, 2024 05:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from cc8affd to 6cb39f0 Compare February 22, 2024 05:39
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 5aec170 to b1c2ef6 Compare February 22, 2024 05:39
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 6cb39f0 to 49de43b Compare February 22, 2024 15:23
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from b1c2ef6 to e1080a5 Compare February 22, 2024 15:23
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 49de43b to 9ec1f91 Compare February 22, 2024 15:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from e1080a5 to a1d15d7 Compare February 22, 2024 15:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 9ec1f91 to 54edbc9 Compare February 22, 2024 21:42
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from a1d15d7 to 805b730 Compare February 22, 2024 21:42
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 54edbc9 to bc33de5 Compare February 22, 2024 22:23
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 805b730 to 78a0415 Compare February 22, 2024 22:23
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from bc33de5 to 7f947f5 Compare February 22, 2024 22:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 78a0415 to 0aecd93 Compare February 22, 2024 22:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 7f947f5 to cb9f0e1 Compare February 22, 2024 23:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 0aecd93 to 0510af0 Compare February 22, 2024 23:50
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from cb9f0e1 to dfc521e Compare February 23, 2024 00:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 0510af0 to 00ea65b Compare February 23, 2024 00:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from dfc521e to 177e120 Compare February 23, 2024 22:55
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 00ea65b to 0b5fff3 Compare February 23, 2024 22:55
This was referenced Feb 24, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 177e120 to fc326a5 Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 0b5fff3 to 98b593d Compare February 24, 2024 03:24
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from fc326a5 to 7ad40dc Compare February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from 98b593d to b07f297 Compare February 24, 2024 09:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-19-add_more_info_into_background_thread branch from 7ad40dc to 531ee3b Compare February 24, 2024 09:20
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-17-more._attempts_at_fixing_tests branch from b07f297 to f6cd473 Compare February 24, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants