-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(LK-C-4) Add controlled QubitUnitary support to Lightning Kokkos #955
Open
josephleekl
wants to merge
6
commits into
lk-control-gate-NQ-multiRZ
Choose a base branch
from
lk-control-matrix-NQ
base: lk-control-gate-NQ-multiRZ
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
josephleekl
changed the title
Lk control matrix nq
Add controlled N-qubit matrix support to Lightning Kokkos
Oct 21, 2024
josephleekl
force-pushed
the
lk-control-gate-NQ-multiRZ
branch
2 times, most recently
from
October 21, 2024 21:01
42f9cd3
to
23f398c
Compare
josephleekl
force-pushed
the
lk-control-matrix-NQ
branch
from
October 21, 2024 21:02
8807e39
to
07c38a1
Compare
josephleekl
added
ci:build_wheels
Activate wheel building.
ci:use-gpu-runner
Enable usage of GPU runner for this Pull Request
urgent
Mark a pull request as high priority
labels
Oct 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-gate-NQ-multiRZ #955 +/- ##
==============================================================
+ Coverage 97.32% 97.53% +0.21%
==============================================================
Files 215 215
Lines 31229 31571 +342
==============================================================
+ Hits 30393 30793 +400
+ Misses 836 778 -58 ☔ View full report in Codecov by Sentry. |
josephleekl
force-pushed
the
lk-control-gate-NQ-multiRZ
branch
from
October 22, 2024 16:00
23f398c
to
bc9d408
Compare
josephleekl
force-pushed
the
lk-control-matrix-NQ
branch
from
October 22, 2024 17:09
07c38a1
to
ce9250e
Compare
josephleekl
changed the title
Add controlled N-qubit matrix support to Lightning Kokkos
Add controlled QubitUnitary support to Lightning Kokkos
Oct 22, 2024
josephleekl
changed the title
Add controlled QubitUnitary support to Lightning Kokkos
(LK-C-4) Add controlled QubitUnitary support to Lightning Kokkos
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:build_wheels
Activate wheel building.
ci:use-gpu-runner
Enable usage of GPU runner for this Pull Request
urgent
Mark a pull request as high priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
This PR adds support for controlled QubitUnitary for Lightning Kokkos. There are specialized implementations for 1/2/3-qubits (
applyNC1/2/3QubitOpFunctor
) and a general case implementation (NCMultiQubitOpFunctor
). These functors are defined inMatrixGateFunctors.hpp
. These are called byapplyControlledMatrix
orapplyOperation
/applyNCMultiQubitOp
inStateVectorKokkos.hpp
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76776]