Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(LK-C-4) Add controlled QubitUnitary support to Lightning Kokkos #955

Open
wants to merge 6 commits into
base: lk-control-gate-NQ-multiRZ
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Oct 21, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:
This PR adds support for controlled QubitUnitary for Lightning Kokkos. There are specialized implementations for 1/2/3-qubits (applyNC1/2/3QubitOpFunctor) and a general case implementation (NCMultiQubitOpFunctor). These functors are defined in MatrixGateFunctors.hpp. These are called by applyControlledMatrix or applyOperation/applyNCMultiQubitOp in StateVectorKokkos.hpp

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-76776]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl changed the title Lk control matrix nq Add controlled N-qubit matrix support to Lightning Kokkos Oct 21, 2024
@josephleekl josephleekl force-pushed the lk-control-gate-NQ-multiRZ branch 2 times, most recently from 42f9cd3 to 23f398c Compare October 21, 2024 21:01
@josephleekl josephleekl added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority labels Oct 21, 2024
@josephleekl josephleekl marked this pull request as ready for review October 21, 2024 21:40
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 99.12791% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.53%. Comparing base (bc9d408) to head (ce9250e).

Files with missing lines Patch % Lines
...nylane_lightning/lightning_kokkos/_state_vector.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           lk-control-gate-NQ-multiRZ     #955      +/-   ##
==============================================================
+ Coverage                       97.32%   97.53%   +0.21%     
==============================================================
  Files                             215      215              
  Lines                           31229    31571     +342     
==============================================================
+ Hits                            30393    30793     +400     
+ Misses                            836      778      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl changed the title Add controlled N-qubit matrix support to Lightning Kokkos Add controlled QubitUnitary support to Lightning Kokkos Oct 22, 2024
@josephleekl josephleekl changed the title Add controlled QubitUnitary support to Lightning Kokkos (LK-C-4) Add controlled QubitUnitary support to Lightning Kokkos Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant