-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(LK-C-1) Add controlled 1-qubit named-gate (e.g. NCPauliX) support to Lightning Kokkos #952
base: lk-control-base
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
4a15f30
to
6d10fad
Compare
d5ae740
to
fd9df9f
Compare
6d10fad
to
aa830a3
Compare
aa830a3
to
38c48b9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-base #952 +/- ##
===================================================
+ Coverage 95.41% 97.44% +2.03%
===================================================
Files 98 215 +117
Lines 12982 30880 +17898
===================================================
+ Hits 12387 30092 +17705
- Misses 595 788 +193 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephleekl ! Nice work. A few Q for the 1st round.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
This PR adds support for named controlled 1-qubit gates (e.g. PauliX / RX / PhaseShift / Hadamard / Rot / GlobalPhase). These are defined in
BasicGateFunctors.hpp
, and are applied throughapplyNC1Functor
defined in the same file.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76773]