-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(LK-C-2) Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos #953
base: lk-control-gate-1Q
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
3df0a20
to
d99ad20
Compare
eaac78f
to
a1c498f
Compare
692c2cf
to
5497be5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-gate-1Q #953 +/- ##
======================================================
+ Coverage 97.38% 97.45% +0.06%
======================================================
Files 215 215
Lines 30840 31188 +348
======================================================
+ Hits 30033 30393 +360
+ Misses 807 795 -12 ☔ View full report in Codecov by Sentry. |
5497be5
to
2d5b58e
Compare
2d5b58e
to
993a6f1
Compare
Missing code coverage due to new gates not tested, they are tested in #955 with the introduction of controlled qubitunitary. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
This PR adds support for named controlled 2/4-qubit gates (e.g. Swap / IsingXX / SingleExcitation / Double Excitation). These are defined in
BasicGateFunctor.hpp
, and are applied throughapplyNC2Functor
andapplyNC4Functor
defined in the same file.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76774]