Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(LK-C-2) Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos #953

Open
wants to merge 10 commits into
base: lk-control-gate-1Q
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Oct 18, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:
This PR adds support for named controlled 2/4-qubit gates (e.g. Swap / IsingXX / SingleExcitation / Double Excitation). These are defined in BasicGateFunctor.hpp, and are applied through applyNC2Functor and applyNC4Functor defined in the same file.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-76774]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl changed the title add native 2/3 qubit controlled gate support to Lightning Kokkos add native 2/3/4 qubit controlled gate support to Lightning Kokkos Oct 19, 2024
@josephleekl josephleekl force-pushed the lk-control-gate-23Q branch 2 times, most recently from eaac78f to a1c498f Compare October 21, 2024 15:17
@josephleekl josephleekl added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Oct 21, 2024
@josephleekl josephleekl marked this pull request as ready for review October 21, 2024 16:08
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 99.85955% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (a01b38a) to head (993a6f1).

Files with missing lines Patch % Lines
...nylane_lightning/lightning_kokkos/_state_vector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           lk-control-gate-1Q     #953      +/-   ##
======================================================
+ Coverage               97.38%   97.45%   +0.06%     
======================================================
  Files                     215      215              
  Lines                   30840    31188     +348     
======================================================
+ Hits                    30033    30393     +360     
+ Misses                    807      795      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl changed the title add native 2/3/4 qubit controlled gate support to Lightning Kokkos Add controlled 2/3/4-qubit gate support to Lightning Kokkos Oct 21, 2024
@josephleekl josephleekl marked this pull request as draft October 21, 2024 19:50
@josephleekl josephleekl marked this pull request as ready for review October 21, 2024 21:03
@josephleekl josephleekl added the urgent Mark a pull request as high priority label Oct 21, 2024
@josephleekl josephleekl changed the title Add controlled 2/3/4-qubit gate support to Lightning Kokkos Add controlled named 2/4-qubit gate support to Lightning Kokkos Oct 22, 2024
@josephleekl josephleekl changed the title Add controlled named 2/4-qubit gate support to Lightning Kokkos Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos Oct 22, 2024
@josephleekl
Copy link
Contributor Author

Missing code coverage due to new gates not tested, they are tested in #955 with the introduction of controlled qubitunitary.

@josephleekl josephleekl changed the title Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos (LK-C-2) Oct 23, 2024
@josephleekl josephleekl changed the title Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos (LK-C-2) (LK-C-2) Add controlled named 2/4-qubit gate (e.g. NCIsingXX) support to Lightning Kokkos Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant