-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(LK-C-3) Add controlled MultiRZ support to Lightning Kokkos #954
base: lk-control-gate-23Q
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lk-control-gate-23Q #954 +/- ##
=======================================================
- Coverage 97.45% 97.32% -0.13%
=======================================================
Files 215 215
Lines 31188 31229 +41
=======================================================
Hits 30393 30393
- Misses 795 836 +41 ☔ View full report in Codecov by Sentry. |
5497be5
to
2d5b58e
Compare
42f9cd3
to
23f398c
Compare
2d5b58e
to
993a6f1
Compare
23f398c
to
bc9d408
Compare
Missing code coverage due to new gates not tested, they are tested in #955 with the introduction of controlled qubitunitary. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
This PR adds support for controlled multiRZ for Lightning Kokkos. This is defined in
BasicGateFunctor.hpp
, and is applied throughapplyNCNFunctor
defined in the same file.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76775]