Correct rotation bug in logrotate #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2024
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
10fe605
to
d57289e
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
197c443
to
75c6706
Compare
goxberry
approved these changes
Oct 2, 2024
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
d57289e
to
dd09a2f
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
f0d2307
to
f442907
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
dd09a2f
to
fb34d2e
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
f442907
to
d4049ef
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
fb34d2e
to
687ad7b
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
d4049ef
to
d48903d
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
687ad7b
to
f9255a3
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
d48903d
to
6dd8100
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
f9255a3
to
a1669f9
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
6dd8100
to
bda20aa
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
a1669f9
to
5deb7c7
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
bda20aa
to
987147c
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
5deb7c7
to
c3f1183
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
c3f1183
to
d2f74d9
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
987147c
to
4054f9f
Compare
blt
changed the base branch from
blt/make_io_errors_paintful_explicit_in_logrotate_generator
to
graphite-base/1024
This commit removes a bug in the logrotate rotation mechanism where renames would cause the child generator crash if more than one historical copy of a log file was kept on disk. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
graphite-base/1024
branch
from
d2f74d9
to
610b5f2
Compare
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
4054f9f
to
f3562af
Compare
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/correct_rotation_bug_in_logrotate
branch
from
f3562af
to
430eb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes a bug in the logrotate rotation mechanism where
renames would cause the child generator crash if more than one historical
copy of a log file was kept on disk.