Add error! logs around logrotate errors #1021
Merged
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
This was referenced Oct 2, 2024
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
from
109bcc6
to
4b5e695
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
4cf9d85
to
11a7f62
Compare
goxberry
approved these changes
Oct 2, 2024
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
from
4b5e695
to
d948795
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
11a7f62
to
32ddd92
Compare
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
from
d948795
to
cdef7aa
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
32ddd92
to
29d14af
Compare
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
from
cdef7aa
to
03fbd6e
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
29d14af
to
f821f6d
Compare
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
from
03fbd6e
to
835a918
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
f821f6d
to
1d07073
Compare
blt
force-pushed
the
blt/remove_debugging_names_info_call
branch
2 times, most recently
from
4f1967a
to
7bf3d13
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
1d07073
to
0f42af8
Compare
blt
changed the base branch from
blt/remove_debugging_names_info_call
to
graphite-base/1021
blt
force-pushed
the
graphite-base/1021
branch
from
7bf3d13
to
b0e61e0
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
0f42af8
to
8bf5399
Compare
I'm working on a theory that lading file-gen runs fail because one of the IO operations that takes place is failing and the error is being silenlty eaten. Unclear if true. This commit also converts any panics to error returns. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
8bf5399
to
76513c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm working on a theory that lading file-gen runs fail because one of the IO
operations that takes place is failing and the error is being silenlty eaten.
Unclear if true. This commit also converts any panics to error returns.