Drop file handle just to be extra certain #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
This was referenced Oct 1, 2024
blt
force-pushed
the
blt/log_pathname_correction
branch
from
d3cb50a
to
33feb50
Compare
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
0a2b510
to
fca2d8e
Compare
goxberry
approved these changes
Oct 2, 2024
blt
force-pushed
the
blt/log_pathname_correction
branch
from
33feb50
to
b932800
Compare
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
fca2d8e
to
e3b7e05
Compare
blt
force-pushed
the
blt/log_pathname_correction
branch
from
b932800
to
8a09196
Compare
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
e3b7e05
to
9931982
Compare
blt
force-pushed
the
blt/log_pathname_correction
branch
2 times, most recently
from
827eab4
to
0cadf9f
Compare
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
9931982
to
31a55e1
Compare
blt
changed the base branch from
blt/log_pathname_correction
to
graphite-base/1019
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
31a55e1
to
3c1cd12
Compare
blt
force-pushed
the
graphite-base/1019
branch
from
0cadf9f
to
086a38e
Compare
This commit drops `fp` whenever we flush it and overwrite `fp`. This is implied by the overwrite, of course, but I found myself wondering about when exactly this operation took place, so now it's explicit. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/drop_file_handle_just_to_be_extra_certain
branch
from
3c1cd12
to
88ecd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit drops
fpwhenever we flush it and overwritefp. Thisis implied by the overwrite, of course, but I found myself wondering
about when exactly this operation took place, so now it's explicit.