Make IO errors paintful explicit in logrotate generator #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2024
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
4cf9d85
to
11a7f62
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
10fe605
to
d57289e
Compare
goxberry
approved these changes
Oct 2, 2024
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
11a7f62
to
32ddd92
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
d57289e
to
dd09a2f
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
32ddd92
to
29d14af
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
dd09a2f
to
fb34d2e
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
29d14af
to
f821f6d
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
fb34d2e
to
687ad7b
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
f821f6d
to
1d07073
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
687ad7b
to
f9255a3
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
from
1d07073
to
0f42af8
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
f9255a3
to
a1669f9
Compare
blt
force-pushed
the
blt/add_error_logs_around_logrotate_errors
branch
2 times, most recently
from
8bf5399
to
76513c6
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
a1669f9
to
5deb7c7
Compare
blt
changed the base branch from
blt/add_error_logs_around_logrotate_errors
to
graphite-base/1022
blt
force-pushed
the
graphite-base/1022
branch
from
76513c6
to
ec1eaf5
Compare
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
5deb7c7
to
c3f1183
Compare
In my downstack PR I discovered that in fact we have some IO error happening in practice although exactly which one who can say. This PR attempts to say. I've gone through and made every error very explicit and where possible added the paths being acted on. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
from
c3f1183
to
d2f74d9
Compare
blt
deleted the
blt/make_io_errors_paintful_explicit_in_logrotate_generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In my downstack PR I discovered that in fact we have some IO error happening
in practice although exactly which one who can say. This PR attempts to say.
I've gone through and made every error very explicit and where possible added
the paths being acted on.