Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: kernel_service: heap: add required header #78670

Merged

Conversation

ycsin
Copy link
Member

@ycsin ycsin commented Sep 18, 2024

Add the "kernel_shell.h" header which is required but missing, causing build error.

Fixes #78668

@zephyrbot zephyrbot added the area: Shell Shell subsystem label Sep 18, 2024
@ycsin ycsin added bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. and removed area: Shell Shell subsystem labels Sep 18, 2024
nashif
nashif previously approved these changes Sep 18, 2024
Add the "kernel_shell.h" header which is required but missing,
causing build error.

Signed-off-by: Yong Cong Sin <[email protected]>
Signed-off-by: Yong Cong Sin <[email protected]>
@ycsin ycsin force-pushed the pr/fix-kernel-shell-heap-header branch from b6582ec to 1b78c6e Compare September 19, 2024 03:18
@ycsin ycsin force-pushed the pr/fix-kernel-shell-heap-header branch from 1b78c6e to 932a301 Compare September 19, 2024 03:56
@ycsin ycsin added size: XS A PR changing only a single line of code and removed area: Samples Samples labels Sep 19, 2024
@ycsin
Copy link
Member Author

ycsin commented Sep 19, 2024

drop everything else leaving just the fix, the test needed more time and will be done in a separate PR (#78680)

@nashif nashif merged commit ae20c08 into zephyrproject-rtos:main Sep 19, 2024
26 checks passed
@ycsin ycsin deleted the pr/fix-kernel-shell-heap-header branch September 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem bug The issue is a bug, or the PR is fixing a bug Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing header in subsys/shell/modules/kernel_service/heap.c
5 participants