-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: kernel_service: heap: add required header #78670
Merged
nashif
merged 1 commit into
zephyrproject-rtos:main
from
ycsin:pr/fix-kernel-shell-heap-header
Sep 19, 2024
Merged
shell: kernel_service: heap: add required header #78670
nashif
merged 1 commit into
zephyrproject-rtos:main
from
ycsin:pr/fix-kernel-shell-heap-header
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
added
bug
The issue is a bug, or the PR is fixing a bug
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
and removed
area: Shell
Shell subsystem
labels
Sep 18, 2024
nashif
previously approved these changes
Sep 18, 2024
bjarki-andreasen
previously approved these changes
Sep 18, 2024
nashif
requested changes
Sep 18, 2024
ycsin
force-pushed
the
pr/fix-kernel-shell-heap-header
branch
from
September 19, 2024 03:12
cada88f
to
b6582ec
Compare
Add the "kernel_shell.h" header which is required but missing, causing build error. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/fix-kernel-shell-heap-header
branch
from
September 19, 2024 03:18
b6582ec
to
1b78c6e
Compare
ycsin
force-pushed
the
pr/fix-kernel-shell-heap-header
branch
from
September 19, 2024 03:56
1b78c6e
to
932a301
Compare
ycsin
added
size: XS
A PR changing only a single line of code
and removed
area: Samples
Samples
labels
Sep 19, 2024
drop everything else leaving just the fix, the test needed more time and will be done in a separate PR (#78680) |
bjarki-andreasen
approved these changes
Sep 19, 2024
nashif
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Shell
Shell subsystem
bug
The issue is a bug, or the PR is fixing a bug
Hotfix
Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
size: XS
A PR changing only a single line of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "kernel_shell.h" header which is required but missing, causing build error.
Fixes #78668