Fix some random errors and warnings #78679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was getting compilation error due to `CONFIG_SHELL_CMD_ROOT` not being defined whe building the sample under certain configurations. The `CONFIG_SHELL_CMD_ROOT` is defined and used only when `CONFIG_SHELL_START_OBSCURED` is enabled, we can simply move it to another file and rely on CMakeLists.txt to compile. Run the `login_init` with `SYS_INIT` so that the `main()` do not need to have knowledge of its existence. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
Update the string formatter according to the type of the variables that it is printing to eliminate compilation warnings. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
zephyrbot
requested review from
alwa-nordic,
carlescufi,
hermabe,
jakub-uC,
jhedberg,
jori-nordic,
kartben,
nashif,
sjanc,
Thalley and
theob-pro
jhedberg
approved these changes
Sep 19, 2024
Thalley
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered some errors and warnings when working on #78670, this PR fixes those