x86: revert removing soc.h from atom soc #69758
Conversation
This was part of the mega hwmv2 commit. Looks like hpet drivers heavily relies on soc.h. Reverting this for now while we look for a proper fix and remove reliance on soc.h for drivers. Signed-off-by: Anas Nashif <[email protected]>
zephyrbot
added
area: Disk Access
area: Bluetooth
platform: X86
zephyrbot
requested review from
alwa-nordic,
andyross,
ceolin,
danieldegrasse,
decsny,
hermabe,
jfischer-no,
jhedberg,
jori-nordic,
laurenmurphyx64,
nordic-krch,
tbursztyka,
teburd and
Thalley
| @@ -18,6 +18,7 @@ | |||
| #include <zephyr/sys/byteorder.h> | |||
| #include <zephyr/debug/stack.h> | |||
| #include <zephyr/sys/__assert.h> | |||
| #include <soc.h> | |||
There was a problem hiding this comment.
This is a bit surprising. What does hci_core.c need this for? I'd have expected to see reports of build failures, etc if it was absolutely necessary there.
| @@ -18,6 +18,7 @@ | |||
| #include <zephyr/sys/byteorder.h> | |||
| #include <zephyr/debug/stack.h> | |||
| #include <zephyr/sys/__assert.h> | |||
| #include <soc.h> | |||
There was a problem hiding this comment.
soc.h should not be on a subsys level file
| #include <zephyr/sys/util.h> | ||
|
|
||
| #ifndef _ASMLANGUAGE | ||
| #include <zephyr/device.h> | ||
| #include <zephyr/random/random.h> | ||
| #endif |
There was a problem hiding this comment.
none of these seem to be required by this file, only toolchain.h for ARG_UNUSED?
|
Guys, I am reverting a commit with this, I do not want to go through partial fixes, will come back to this and give it another go, but this is blocking and breaking few platforms and I do not want to be selective in the revert. The commit in question: I know some of those might not be needed, thats why I originally removed them. |
gmarull
dismissed
their stale review
unblocking, can be taken as a revert for now, but please, open a PR fixing the trivial issues
nashif
added
Hotfix
|
I'm working on #78670 and trying to incorporate test into |
This was part of the mega hwmv2 commit. Looks like hpet drivers heavily
relies on soc.h. Reverting this for now while we look for a proper fix
and remove reliance on soc.h for drivers.
Signed-off-by: Anas Nashif [email protected]