Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

ssekar15 · 2024-06-21T07:39:59Z

PR covers

Add mipi ltdc display shield support for stm32f769i_disco board
Replace direct hal api for ltdc block reset to zephyr reset api framework

dts/arm/st/f4/stm32f429.dtsi

danieldegrasse · 2024-06-22T03:04:14Z

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32f769i_disco.overlay

If there are multiple ST boards that support the ST_B_LCD40_DSI1_MB1166 shield, then you might consider defining node labels for connectors (IE for the LTDC, MIPI DSI, and I2C connections). This has been done for some NXP supplied displays, see here:

zephyr/boards/shields/rk055hdmipi4ma0/rk055hdmipi4ma0.overlay

Line 1 in 59632d5

/*

. This avoids code duplication (for example, the display panel timings look the same as the ones here:

zephyr/boards/shields/st_b_lcd40_dsi1_mb1166/boards/st_b_lcd40_dsi1_mb1166/stm32h747i_disco_stm32h747xx_m7.overlay

Line 1 in 59632d5

/*

It seems this is already being done for the GPIO nexus node, so expanding this to the peripherals might be useful

Touch and display controller are part of shield overlay. If I'm not wrong not all the STM chipset has LTDC, so the panel display timings in ltdc node shall be in board overlay.

Sure, not all the STM SOCs will have an LTDC- this is the case with NXP's SOCs as well. In the case of NXP's displays, we sell multiple display modules that connect via a 40 pin FPC present on several of our evaluation kits to the module itself. The benefit here is that if we designed a new SOC with a DSI interface and added the same 40 pin connector, we could enable support for these displays by simply adding node definitions at the board level.

Beyond this, if a customer wanted to use this shield with their custom board, they would not need to modify Zephyr itself to add a new overlay (or duplicate the overlay definition for their board out of tree).

This is a core idea of a shield- not every evaluation kit supported by Zephyr has a SPI interface broken out to arduino headers, but those that do can use a large subset of all Zephyr shields without board specific configuration. Of course the scope of this shield would be more narrow (perhaps 2-3 boards), but I think the benefits to this approach still apply.

@ssekar15 see https://github.com/ajarmouni-st/zephyr_dev/tree/fix_mb1166_shield
@danieldegrasse is this more or less what you meant?

Sorry for the delayed response- yeah, this looks right to me. Essentially just refactor the shields to avoid duplicating things in board-specific shield overlays

boards/st/stm32f769i_disco/stm32f769i_disco.dts

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32f769i_disco.conf

boards/st/stm32h747i_disco/stm32h747i_disco_stm32h747xx_m7.dts

boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32h747i_disco_stm32h747xx_m7.overlay

drivers/display/display_stm32_ltdc.c

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig

ajarmouni-st · 2024-07-02T12:52:32Z

/

ok, what kind of problem? May I know how does correct one looks in other board?

ajarmouni-st · 2024-07-02T12:56:10Z

/

ok, what kind of problem? May I know how does correct one looks in other board?

As a side note, you can run the sample on your PC (tested on Ubuntu laptop) using:

west build -p always -b native_posix/native/64 samples/drivers/display
west build -t run

ajarmouni-st

Adding the board to the different test cases of st_b_lcd40_dsi1_mb1166 would also be needed.

diff --git a/samples/drivers/display/sample.yaml b/samples/drivers/display/sample.yaml
index 33d72e11c74..8e708140e68 100644
--- a/samples/drivers/display/sample.yaml
+++ b/samples/drivers/display/sample.yaml
@@ -132,7 +132,9 @@ tests:
       fixture: fixture_display
   sample.display.st_b_lcd40_dsi1_mb1166:
     filter: dt_compat_enabled("orisetech,otm8009a")
-    platform_allow: stm32h747i_disco/stm32h747xx/m7
+    platform_allow:
+      - stm32h747i_disco/stm32h747xx/m7
+      - stm32f769i_disco
     extra_args: SHIELD=st_b_lcd40_dsi1_mb1166
     tags:
       - display
diff --git a/samples/modules/lvgl/demos/sample.yaml b/samples/modules/lvgl/demos/sample.yaml
index 5a9d668d02d..eea1ed0b127 100644
--- a/samples/modules/lvgl/demos/sample.yaml
+++ b/samples/modules/lvgl/demos/sample.yaml
@@ -26,7 +26,9 @@ tests:
       - CONFIG_LV_Z_DEMO_WIDGETS=y
   sample.modules.lvgl.demos.st_b_lcd40_dsi1_mb1166:
     filter: dt_compat_enabled("orisetech,otm8009a")
-    platform_allow: stm32h747i_disco/stm32h747xx/m7
+    platform_allow:
+      - stm32h747i_disco/stm32h747xx/m7
+      - stm32f769i_disco
     extra_args: SHIELD=st_b_lcd40_dsi1_mb1166
     harness: console
     harness_config:
diff --git a/samples/subsys/display/lvgl/sample.yaml b/samples/subsys/display/lvgl/sample.yaml
index 94b26bc1087..c2715fe6c55 100644
--- a/samples/subsys/display/lvgl/sample.yaml
+++ b/samples/subsys/display/lvgl/sample.yaml
@@ -42,7 +42,9 @@ tests:
       - mimxrt1170_evk/mimxrt1176/cm7
   sample.subsys.display.lvgl.st_b_lcd40_dsi1_mb1166:
     filter: dt_compat_enabled("orisetech,otm8009a")
-    platform_allow: stm32h747i_disco/stm32h747xx/m7
+    platform_allow:
+      - stm32h747i_disco/stm32h747xx/m7
+      - stm32f769i_disco
     extra_args: SHIELD=st_b_lcd40_dsi1_mb1166
     harness: console
     harness_config:

dts/bindings/clock/st,stm32f7-pll-clock.yaml

boards/st/stm32h747i_disco/stm32h747i_disco_stm32h747xx_m7.dts

erwango · 2024-07-04T13:22:15Z

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig

 if LVGL

+if BOARD_STM32H747I_DISCO_STM32H747XX_M7


I'd rather add a orsource "boards/*.defconfig" then do this in a boards/shields/st_b_lcd40_dsi1_mb1166/boards/stm32h747i_disco_stm32h747xx_m7.defconfig

erwango · 2024-07-04T13:30:42Z

Few comments from my part. Don't hesitate to dismiss my review once done, as will be OoO for few weeks.

ssekar15 · 2024-07-12T04:02:17Z

@ssekar15 stm32h747i_disco is looking good, will test stm32f769i_disco next.

@ssekar15 There seems to be a problem with samples/drivers/display on stm32f769i-disco, haven't looked into it yet. !

@ajarmouni-st
Related to display shift !

#32286

Dismissing as I'm no longer active on this work account.

erwango

@ssekar15 One more comment that was left pending, but I'll need to review this entirely. Would you mind rebasing to solve merge conflicts ?

erwango · 2024-07-30T15:00:17Z

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig

 if LVGL

-config STM32_LTDC_FB_NUM
-	default 0
+orsource "boards/*.defconfig"


Nit: this line should be outside of if LVGL

Add support for STM32F7 MIPI DSI host driver. Signed-off-by: Saravanan Sekar <[email protected]>

Add bindings for pll-r used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

Add pll-r clock used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

Use common pin reference for STMicroelectronics B-LCD40-DSI1 shield from board header mapping. Signed-off-by: Saravanan Sekar <[email protected]>

Enhanced lvgl config to improve performance for board stm32h747i_disco impacts the compilation issue on low memory footprint stm32f769i_disco. region `IDT_LIST' overflowed by 121081 bytes bss ' will not fit in region `RAM' ld.bfd: region `RAM' overflowed by 1220664 bytes collect2: error: ld returned 1 exit status Signed-off-by: Saravanan Sekar <[email protected]>

Capacitive touch ft6202 is not part board, remove in board dts and move to panel st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

Add support for STMicroelectronics B-LCD40-DSI1 shield to stm32f769i_disco board. Default config for lvgl is adjusted to lower value to fix compilation issue on low memory footprint stm32f769i_disco. region `IDT_LIST' overflowed by 121081 bytes bss ' will not fit in region `RAM' ld.bfd: region `RAM' overflowed by 1220664 bytes collect2: error: ld returned 1 exit status Signed-off-by: Saravanan Sekar <[email protected]>

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

JarmouniA · 2024-09-01T10:41:04Z

@ssekar15 Hello again from my personal account :)
Has the shift issue on stm32f769i-disco been solved? I no longer have access to hardware to verify it.

ssekar15 · 2024-09-02T03:11:30Z

@ssekar15 Hello again from my personal account :) Has the shift issue on stm32f769i-disco been solved? I no longer have access to hardware to verify it.

Unfortunately no.. I have tried with offset and different setting but didn't work

zephyrbot added area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32 area: Display area: Devicetree Binding PR modifies or adds a Device Tree binding area: Clock Control labels Jun 21, 2024

zephyrbot requested review from ajarmouni-st, avisconti, danieldegrasse, decsny, erwango, FRASTM, galak, gautierg-st, GeorgeCGV, jfischer-no, kartben, marwaiehm-st and nordic-krch June 21, 2024 07:40

zephyrbot assigned kartben Jun 21, 2024

ssekar15 force-pushed the disp_f769_disco branch from b343eaf to 8ba69eb Compare June 21, 2024 13:55

danieldegrasse reviewed Jun 22, 2024

View reviewed changes

ssekar15 force-pushed the disp_f769_disco branch 2 times, most recently from 6ac49fc to 36d4ccf Compare June 26, 2024 08:44

ajarmouni-st requested changes Jun 26, 2024

View reviewed changes

boards/st/stm32f769i_disco/stm32f769i_disco.dts Outdated Show resolved Hide resolved

ajarmouni-st requested changes Jun 26, 2024

View reviewed changes

ajarmouni-st mentioned this pull request Jun 27, 2024

stm32: mipi-dsi on F4 and F7 #74938

Open

ssekar15 force-pushed the disp_f769_disco branch from 36d4ccf to 8a331da Compare June 28, 2024 05:59

ssekar15 requested a review from ajarmouni-st June 28, 2024 06:01

ajarmouni-st requested changes Jun 28, 2024

View reviewed changes

drivers/display/display_stm32_ltdc.c Outdated Show resolved Hide resolved

boards/shields/st_b_lcd40_dsi1_mb1166/Kconfig.defconfig Show resolved Hide resolved

ssekar15 force-pushed the disp_f769_disco branch from 8a331da to 6b80813 Compare June 28, 2024 12:45

ajarmouni-st reviewed Jul 3, 2024

View reviewed changes

zephyrbot added the area: Samples Samples label Jul 4, 2024

zephyrbot requested a review from nashif July 4, 2024 06:51

erwango requested changes Jul 4, 2024

View reviewed changes

ssekar15 force-pushed the disp_f769_disco branch from 71c1232 to b22b3d2 Compare July 12, 2024 03:42

ssekar15 force-pushed the disp_f769_disco branch from b22b3d2 to 49e9b5e Compare July 19, 2024 05:33

ssekar15 requested a review from ajarmouni-st July 25, 2024 04:54

ajarmouni-st removed their request for review July 25, 2024 08:05

erwango reviewed Aug 29, 2024

View reviewed changes

ssekar15 added 10 commits August 30, 2024 13:19

dts: arm: st: Add STM32F7 DSI host driver

013b032

Add support for STM32F7 MIPI DSI host driver. Signed-off-by: Saravanan Sekar <[email protected]>

dts: bindings: clock: Add pll-r for PLLDSICLK clock

a162834

Add bindings for pll-r used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

boards: stm32f769i_disco: add pll-r for PLLDSICLK clock

df91691

Add pll-r clock used for DSI HOST peripheral byte clock. Signed-off-by: Saravanan Sekar <[email protected]>

boards: shield: add dsi-lcd display header mapping for stm32h747i_disco

436e99b

Use common pin reference for STMicroelectronics B-LCD40-DSI1 shield from board header mapping. Signed-off-by: Saravanan Sekar <[email protected]>

boards: stm32f769i_disco: remove capacitive touch ft6202

e56c19d

Capacitive touch ft6202 is not part board, remove in board dts and move to panel st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

1f9330b

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

d3e49e8

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

samples: add disp_f769_disco to display samples with shield

471d921

Add disp_f769_disco board to platform-allow list for display sample tests with st_b_lcd40_dsi1_mb1166 shield. Signed-off-by: Saravanan Sekar <[email protected]>

ssekar15 force-pushed the disp_f769_disco branch from 49e9b5e to 471d921 Compare August 30, 2024 07:50

JarmouniA mentioned this pull request Sep 1, 2024

boards: shields: st_b_lcd40_dsi1_mb1166: refactoring #77854

Merged

ssekar15 requested review from erwango and danieldegrasse September 23, 2024 04:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

ssekar15 commented Jun 21, 2024

danieldegrasse Jun 22, 2024

ssekar15 Jun 26, 2024

danieldegrasse Jul 3, 2024

ajarmouni-st Jul 4, 2024

danieldegrasse Jul 26, 2024

ajarmouni-st commented Jul 2, 2024

ajarmouni-st commented Jul 2, 2024

ajarmouni-st left a comment •

edited

Loading

erwango Jul 4, 2024

erwango commented Jul 4, 2024

ssekar15 commented Jul 12, 2024

erwango left a comment

erwango Jul 30, 2024

JarmouniA commented Sep 1, 2024

ssekar15 commented Sep 2, 2024

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

Are you sure you want to change the base?

Add st_b_lcd40_dsi1_mb1166 display shield support for stm32f769i_disco board #74646

Conversation

ssekar15 commented Jun 21, 2024

danieldegrasse Jun 22, 2024

Choose a reason for hiding this comment

ssekar15 Jun 26, 2024

Choose a reason for hiding this comment

danieldegrasse Jul 3, 2024

Choose a reason for hiding this comment

ajarmouni-st Jul 4, 2024

Choose a reason for hiding this comment

danieldegrasse Jul 26, 2024

Choose a reason for hiding this comment

ajarmouni-st commented Jul 2, 2024

ajarmouni-st commented Jul 2, 2024

ajarmouni-st left a comment • edited Loading

Choose a reason for hiding this comment

erwango Jul 4, 2024

Choose a reason for hiding this comment

erwango commented Jul 4, 2024

ssekar15 commented Jul 12, 2024

erwango left a comment

Choose a reason for hiding this comment

erwango Jul 30, 2024

Choose a reason for hiding this comment

JarmouniA commented Sep 1, 2024

ssekar15 commented Sep 2, 2024

ajarmouni-st left a comment •

edited

Loading