arch: cleanup EXCEPTION_STACK_TRACE dependencies #73376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
edersondisouza,
laurenmurphyx64,
mrkhldn and
najumon1980
ycsin
force-pushed
the
pr/exception_stack_trace_cleanup_x86
branch
from
0d0ceda
to
98a524a
Compare
dcpleung
reviewed
May 28, 2024
ycsin
force-pushed
the
pr/exception_stack_trace_cleanup_x86
branch
from
98a524a
to
56478ed
Compare
ycsin
commented
May 29, 2024
The `PRINTK` was required for `EXCEPTION_STACK_TRACE` because it's initial implementation for x86 in zephyrproject-rtos#6653 uses `printk()`. We are using `LOG_ERR()` now, so this is not required anymore. Signed-off-by: Yong Cong Sin <[email protected]>
The `DEBUG_INFO` in the `EXCEPTION_STACK_TRACE` is only required by x86. Move that to `X86_EXCEPTION_STACK_TRACE` instead. Signed-off-by: Yong Cong Sin <[email protected]>
Not all stack trace implementation requires frame pointer, move that dependency to architecture Kconfig. Signed-off-by: Yong Cong Sin <[email protected]>
Select `DEBUG_INFO` instead of depending on it. Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/exception_stack_trace_cleanup_x86
branch
from
56478ed
to
92daf5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Please review #73288 instead, thanks.
Move X86's dependencies from
EXCEPTION_STACK_TRACEtoX86_EXCEPTION_STACK_TRACE