debug: remove !OMIT_FRAME_POINTER from EXCEPTION_STACK_TRACE

Not all stack trace implementation requires frame pointer, move that dependency to architecture Kconfig. Signed-off-by: Yong Cong Sin <[email protected]>
zephyrproject-rtos · May 28, 2024 · 98a524a · 98a524a
1 parent 1708140
commit 98a524a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/arch/x86/core/Kconfig.ia32 b/arch/x86/core/Kconfig.ia32
@@ -168,6 +168,7 @@ config X86_EXCEPTION_STACK_TRACE
 	default y
 	depends on EXCEPTION_STACK_TRACE
 	depends on DEBUG_INFO
+	depends on !OMIT_FRAME_POINTER
 	help
 	  Internal config to enable runtime stack traces on fatal exceptions.
 

diff --git a/arch/x86/core/Kconfig.intel64 b/arch/x86/core/Kconfig.intel64
@@ -34,6 +34,7 @@ config X86_EXCEPTION_STACK_TRACE
 	default y
 	depends on EXCEPTION_STACK_TRACE
 	depends on DEBUG_INFO
+	depends on !OMIT_FRAME_POINTER
 	depends on NO_OPTIMIZATIONS
 	help
 	  Internal config to enable runtime stack traces on fatal exceptions.

diff --git a/subsys/debug/Kconfig b/subsys/debug/Kconfig
@@ -381,7 +381,6 @@ config SYMTAB
 config EXCEPTION_STACK_TRACE
 	bool "Attempt to print stack traces upon exceptions"
 	default y
-	depends on !OMIT_FRAME_POINTER
 	help
 	  If the architecture fatal handling code supports it, attempt to
 	  print a stack trace of function memory addresses when an

diff --git a/tests/arch/common/stack_unwind/testcase.yaml b/tests/arch/common/stack_unwind/testcase.yaml
@@ -32,6 +32,7 @@ tests:
     extra_configs:
       - CONFIG_NO_OPTIMIZATIONS=y
       - CONFIG_DEBUG_INFO=y
+      - CONFIG_OMIT_FRAME_POINTER=n
     integration_platforms:
       - qemu_x86
       - qemu_x86_64