Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: cleanup EXCEPTION_STACK_TRACE dependencies #73376

Closed
wants to merge 4 commits into from
Closed

arch: cleanup EXCEPTION_STACK_TRACE dependencies #73376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff0d248
debug: remove PRINTK from EXCEPTION_STACK_TRACE
ycsin May 25, 2024
d29632f
debug: remove DEBUG_INFO from EXCEPTION_STACK_TRACE
ycsin May 25, 2024
8cfacf6
debug: remove `!OMIT_FRAME_POINTER` from EXCEPTION_STACK_TRACE
ycsin May 25, 2024
92daf5c
arch: x86: select DEBUG_INFO in X86_EXCEPTION_STACK_TRACE
ycsin May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions arch/x86/core/Kconfig.ia32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ endmenu
config X86_EXCEPTION_STACK_TRACE
bool
default y
select DEBUG_INFO
depends on EXCEPTION_STACK_TRACE
depends on !OMIT_FRAME_POINTER
help
Internal config to enable runtime stack traces on fatal exceptions.

Expand Down
2 changes: 2 additions & 0 deletions arch/x86/core/Kconfig.intel64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ config X86_EXCEPTION_STACK_SIZE
config X86_EXCEPTION_STACK_TRACE
bool
default y
select DEBUG_INFO
depends on EXCEPTION_STACK_TRACE
depends on !OMIT_FRAME_POINTER
depends on NO_OPTIMIZATIONS
help
Internal config to enable runtime stack traces on fatal exceptions.
Expand Down
3 changes: 0 additions & 3 deletions subsys/debug/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,6 @@ config SYMTAB
config EXCEPTION_STACK_TRACE
bool "Attempt to print stack traces upon exceptions"
default y
depends on PRINTK
depends on DEBUG_INFO
depends on !OMIT_FRAME_POINTER
help
If the architecture fatal handling code supports it, attempt to
print a stack trace of function memory addresses when an
Expand Down
1 change: 0 additions & 1 deletion tests/arch/common/stack_unwind/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ CONFIG_LOG_BUFFER_SIZE=2048

CONFIG_EXCEPTION_STACK_TRACE=y
CONFIG_DEBUG=y
CONFIG_DEBUG_INFO=y
1 change: 1 addition & 0 deletions tests/arch/common/stack_unwind/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ tests:
arch_allow: x86
extra_configs:
- CONFIG_NO_OPTIMIZATIONS=y
- CONFIG_OMIT_FRAME_POINTER=n
integration_platforms:
- qemu_x86
- qemu_x86_64
Expand Down
Loading