Attempt to fix SOF upgrade #69547
Closed
Attempt to fix SOF upgrade #69547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
added
hwmv2-likely-conflict
|
The first of these commits has also been submitted separately as #69480 |
nordicjm
requested changes
Mar 4, 2024
nordicjm
removed
hwmv2-likely-conflict
The GEN bit status cannot be immediately read back, so modify DGCS in one write. Signed-off-by: Kai Vehmanen <[email protected]>
This function should return true only if DGCS_GEN bit is set. Having only DGCS_FIFORDY set is not sufficient to consider the channel to be enabled. Signed-off-by: Kai Vehmanen <[email protected]>
Setting the Power Active bit to the off state before powering up the core requires a minimum delay Signed-off-by: Adrian Bonislawski <[email protected]>
Clearing the LL DONE bit tells the DMAC that this LLI descriptor can be executed again to initiate another transfer. This should always be done prior to START but not during STOP. STOP needs all the LLI descriptors DONE to be set so that any LLI load will stop the DMA state machine. Signed-off-by: Liam Girdwood <[email protected]>
Currently channel start unmasks several IRQ sources depending on DMA configuration but DMA stop does not remask them. Fix this. Also clear and unhandled or dont care IRQ at channel stop. Signed-off-by: Liam Girdwood <[email protected]>
On Intel ADSP platforms, addition "isync" is needed in interrupt vector to synchronize icache when interrupt is received when core is in deeper sleep state. Signed-off-by: Kai Vehmanen <[email protected]>
This reverts commit b9d4b9d.
On Intel ADSP we choose to only serve the timer interrupt on the primary core. Signed-off-by: Guennadi Liakhovetski <[email protected]>
power_down() locks the cache line, containing the address, passed to the function in its second argument. However, current builds cause an "alloca" DSP exception when trying to lock that cache line. Aligning that variable on a cache-line size border fixes the problem. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes SOF now can be made to pass CI tests again thesofproject/sof#8732 Please comment and advise how to merge these fixes