board: MIMXRT1062-FMURT6: Add pinmux support for uart ports used for gps and telemtry. #58047

sumitbatra-nxp · 2023-05-19T06:43:02Z

This patch configures the correct pinmux settings for -

lpuart2, lpuart3, lpuart5 ports used for gps and telemetry modules.
It also adds software pull up for the UART console port lpuart7 to
It fixes an issue in ref clock configuration for ETH2 module
It also increases the RAM size

danieldegrasse · 2023-05-31T12:51:37Z

boards/arm/mimxrt1062_fmurt6/mimxrt1062_fmurt6.dts

@@ -33,6 +33,9 @@
 		zephyr,console = &lpuart7;
 		zephyr,shell-uart = &lpuart7;
 		zephyr,canbus = &flexcan1;
+		zephyr,gps1 = &lpuart2;


Are these well known Zephyr chosen node names? I don't see them being used anywhere in the tree. I would rather see these node names be devicetree aliases if these UART connections are being used in a downstream project

Changed from Chosen to Aliases as suggested

danieldegrasse · 2023-05-31T12:52:49Z

drivers/ethernet/eth_mcux.c

+	/* Set ENET2 ref clock to be generated by External OSC,*/
+	/* direction as output and frequency to 50MHz */
+#if DT_NODE_HAS_STATUS(DT_NODELABEL(enet2), okay)
+	IOMUXC_GPR->GPR1 |= (IOMUXC_GPR_GPR1_ENET2_CLK_SEL_MASK |


This looks like it should be handled at the soc_rt10xx.c level, not within the driver. Also, is there an IOMUXC API present for this bit, like kIOMUXC_GPR_ENET1TxClkOutputDir for ENET1?

Thanks @danieldegrasse .. I have modified as per your recommendation.. please check now..

sumitbatra-nxp · 2023-06-06T17:15:42Z

@danieldegrasse .. can you please re-check..
@dleach02.. @mmahadevan108 can you please review

bperseghetti · 2023-06-07T18:50:02Z

@danieldegrasse we added the issues for the bug report fixs and linked them.

danieldegrasse · 2023-06-14T14:03:39Z

boards/arm/mimxrt1062_fmurt6/mimxrt1062_fmurt6.dts

 		gps1 = &lpuart2;
 		telem1 = &lpuart3;
 		telem4-gps2 = &lpuart5;
 	};

+	pwm_shell: pwm_shell {


the commit title MIMXRT1062-FMURT6: Fix PWM device names. Should be updated to something like the following:
soc: arm: nxp_imx: fix PWM node names

used for gps and telemtry. This patch configures the correct pinmux settings for lpuart2, lpuart3, lpuart5 ports used for gps and telemetry modules. It also adds software pull up for the UART console port lpuart7. Signed-off-by: Sumit Batra <[email protected]> Co-authored-by: Benjamin Perseghetti <[email protected]> Co-authored-by: Iain Galloway <[email protected]>

…ists This patch removes an unncessary message for presence or absence of DISPLAY Signed-off-by: Sumit Batra <[email protected]>

danieldegrasse · 2023-06-20T15:07:10Z

soc/arm/nxp_imx/rt/soc_rt10xx.c

@@ -66,7 +66,12 @@ const clock_enet_pll_config_t ethPllConfig = {
 #else
 	.enableClkOutput25M = false,
 #endif
+#if DT_NODE_HAS_STATUS(DT_NODELABEL(enet), okay)


Commit message here needs to be to something like- soc: rt10xx: fix the sequence of Enet2 ref clk enablement

Commit title/message now updated.

danieldegrasse · 2023-06-20T15:07:49Z

boards/arm/mimxrt1062_fmurt6/mimxrt1062_fmurt6.dts

@@ -143,6 +142,7 @@
 	pinctrl-0 = <&pinmux_flexcan3>;
 	pinctrl-names = "default";
 	bus-speed = <125000>;
+	bus-speed-data = <1000000>;


Please move the board changes for bus speed and prescaler settings to another commit, since this one is titled soc: arm: nxp_imxrt1062: fix PWM node names.

Done. Split it out into:

board: MIMXRT1062-FMURT6: Set CANFD bus-speed-data

board: MIMXRT1062-FMURT6: correct PWM prescaler

and renamed it to be more proper with:

soc: nxp_rt10xx: add unique PWM names.

This patch sets ENET2 ref clock to be generated by External OSC ENET2 ref clock direction as output ENET2 ref clk frequency to 50MHz Signed-off-by: Sumit Batra <[email protected]>

Enable PWM to use unique device names. Signed-off-by: Benjamin Perseghetti <[email protected]>

This commit adds the Pinmux and Pad settings for FMU PPM Input Pin Signed-off-by: Sumit Batra <[email protected]>

This patch adds the pinmux and pad settings for I2C3 SDA and SCL pins Signed-off-by: Sumit Batra <[email protected]>

Set the PWM clock prescaler values to 64 for controlling standard servo 50Hz carrier frequency. Signed-off-by: Benjamin Perseghetti <[email protected]>

Set the flexcan3 bus-speed-data to allow for correct CANFD data-speed. Signed-off-by: Benjamin Perseghetti <[email protected]>

sumitbatra-nxp · 2023-07-03T17:32:01Z

@mmahadevan108 .. Can you kindly review, as we need a second approver as well.

sumitbatra-nxp requested review from mmahadevan108 and dleach02 as code owners May 19, 2023 06:43

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch from 57f3e09 to bb6b964 Compare May 19, 2023 07:06

sumitbatra-nxp requested a review from tbursztyka as a code owner May 30, 2023 19:13

zephyrbot added platform: NXP NXP area: Ethernet labels May 30, 2023

zephyrbot requested review from danieldegrasse, dbaluta, decsny, DerekSnell, EmilioCBen, iuliana-prodan, manuargue and yvanderv May 30, 2023 19:13

zephyrbot assigned dleach02 May 30, 2023

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch 4 times, most recently from e07c27a to affb7d4 Compare May 31, 2023 06:05

danieldegrasse reviewed May 31, 2023

View reviewed changes

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch 5 times, most recently from e4d2baf to e8c4565 Compare June 4, 2023 18:27

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch 2 times, most recently from 19b49b3 to 7b6d353 Compare June 7, 2023 09:14

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch 2 times, most recently from 251e5e6 to bb7e50c Compare June 7, 2023 11:27

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch from bb7e50c to 951b3d8 Compare June 7, 2023 12:00

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch from 951b3d8 to 7b6d353 Compare June 7, 2023 18:48

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch 3 times, most recently from d6c09e9 to 58be408 Compare June 8, 2023 19:00

carlescufi requested review from danieldegrasse and gmarull June 14, 2023 10:34

danieldegrasse reviewed Jun 14, 2023

View reviewed changes

sumitbatra-nxp force-pushed the pr-mimxrt1062-fmurt6 branch 4 times, most recently from a375f58 to 460e409 Compare June 16, 2023 09:44

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch from 552ad79 to d1c9f52 Compare June 17, 2023 01:46

sumitbatra-nxp and others added 2 commits June 16, 2023 21:55

board: MIMXRT1062-FMURT6: Removing the CONFIG_DISPLAY check in CMakeL…

65ee33e

…ists This patch removes an unncessary message for presence or absence of DISPLAY Signed-off-by: Sumit Batra <[email protected]>

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch from d1c9f52 to 87796aa Compare June 17, 2023 01:56

danieldegrasse reviewed Jun 20, 2023

View reviewed changes

sumitbatra-nxp and others added 6 commits June 27, 2023 14:11

soc: rt10xx: fix the sequence of Enet2 ref clk enablement

ea73d93

This patch sets ENET2 ref clock to be generated by External OSC ENET2 ref clock direction as output ENET2 ref clk frequency to 50MHz Signed-off-by: Sumit Batra <[email protected]>

soc: nxp_rt10xx: add unique PWM names.

c4741e9

Enable PWM to use unique device names. Signed-off-by: Benjamin Perseghetti <[email protected]>

board: MIMXRT1062-FMURT6: Add pinmux support for FMU PPM Input

69573b3

This commit adds the Pinmux and Pad settings for FMU PPM Input Pin Signed-off-by: Sumit Batra <[email protected]>

board: MIMXRT1062-FMURT6: Add pinmux support for I2C3 module Pins

fcefd43

This patch adds the pinmux and pad settings for I2C3 SDA and SCL pins Signed-off-by: Sumit Batra <[email protected]>

board: MIMXRT1062-FMURT6: correct PWM prescaler

ea621c2

Set the PWM clock prescaler values to 64 for controlling standard servo 50Hz carrier frequency. Signed-off-by: Benjamin Perseghetti <[email protected]>

board: MIMXRT1062-FMURT6: Set CANFD bus-speed-data

3e41f15

Set the flexcan3 bus-speed-data to allow for correct CANFD data-speed. Signed-off-by: Benjamin Perseghetti <[email protected]>

bperseghetti force-pushed the pr-mimxrt1062-fmurt6 branch from 87796aa to 3e41f15 Compare June 27, 2023 18:35

danieldegrasse approved these changes Jul 3, 2023

View reviewed changes

mmahadevan108 approved these changes Jul 3, 2023

View reviewed changes

mmahadevan108 merged commit fe0efb4 into zephyrproject-rtos:main Jul 3, 2023
16 checks passed

bperseghetti deleted the pr-mimxrt1062-fmurt6 branch July 3, 2023 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

board: MIMXRT1062-FMURT6: Add pinmux support for uart ports used for gps and telemtry. #58047

board: MIMXRT1062-FMURT6: Add pinmux support for uart ports used for gps and telemtry. #58047

sumitbatra-nxp commented May 19, 2023 •

edited

Loading

danieldegrasse May 31, 2023

sumitbatra-nxp Jun 2, 2023

danieldegrasse May 31, 2023

sumitbatra-nxp Jun 4, 2023

sumitbatra-nxp commented Jun 6, 2023

bperseghetti commented Jun 7, 2023

danieldegrasse Jun 14, 2023

sumitbatra-nxp Jun 15, 2023

danieldegrasse Jun 20, 2023

bperseghetti Jun 27, 2023

danieldegrasse Jun 20, 2023

bperseghetti Jun 27, 2023

sumitbatra-nxp commented Jul 3, 2023

board: MIMXRT1062-FMURT6: Add pinmux support for uart ports used for gps and telemtry. #58047

board: MIMXRT1062-FMURT6: Add pinmux support for uart ports used for gps and telemtry. #58047

Conversation

sumitbatra-nxp commented May 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sumitbatra-nxp commented Jun 6, 2023

bperseghetti commented Jun 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sumitbatra-nxp commented Jul 3, 2023

sumitbatra-nxp commented May 19, 2023 •

edited

Loading