Build evergreen specific test targets only for non-windows platforms #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
force-pushed
the
revert-1873-revert-1662-separate_eg_modular
branch
from
77b979a
to
6d620e0
Compare
niranjanyardi
changed the base branch from
revert-1873-revert-1662-separate_eg_modular
to
main
niranjanyardi
force-pushed
the
revert-1873-revert-1662-separate_eg_modular
branch
from
2ce1f1d
to
a563218
Compare
hlwarriner
approved these changes
Nov 6, 2023
|
Running internal tests : go/cobalt-cl/269031 : passed |
Change-Id: Iac3266df52a776df3eb4bdc814ad8413586d55c3
niranjanyardi
force-pushed
the
revert-1873-revert-1662-separate_eg_modular
branch
from
a563218
to
4347409
Compare
Codecov Report
@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
- Coverage 57.77% 57.75% -0.03%
==========================================
Files 1915 1915
Lines 95118 95118
==========================================
- Hits 54959 54934 -25
- Misses 40159 40184 +25 |
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
…1918) Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 (cherry picked from commit 34c46ca)
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
Adding TODO statements from feedback in #1918 b/309493306
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
…1918) Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 (cherry picked from commit 34c46ca)
niranjanyardi
added
cp-24.lts.1+
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
…non-windows platforms (#1924) Refer to the original PR: #1918 Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 Co-authored-by: Niranjan Yardi <[email protected]>
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
niranjanyardi
added a commit
that referenced
this pull request
Nov 8, 2023
…1937) Refer to the original PR: #1925 Adding TODO statements from feedback in #1918 b/309493306 Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
…outube#1918) Reverts youtube#1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Adding TODO statements from feedback in youtube#1918 b/309493306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1873 partially
Internal failures have been fixed.
Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment.
b/302008891