Skip to content

Commit

Permalink
Add TODO statements from previous PR feedback (#1925)
Browse files Browse the repository at this point in the history
Adding TODO statements from feedback in
#1918

b/309493306
  • Loading branch information
niranjanyardi committed Nov 7, 2023
1 parent d72cc24 commit 5eb5f80
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions starboard/elf_loader/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ if (sb_is_evergreen_compatible) {
}
}

# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms.
if (current_toolchain == starboard_toolchain && !is_host_win) {
target(starboard_level_final_executable_type, "elf_loader_sandbox") {
data_deps = [ "//third_party/icu:icudata" ]
Expand Down Expand Up @@ -157,6 +158,7 @@ if (sb_is_evergreen_compatible) {
}
}

# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms.
if (!is_host_win) {
target(gtest_target_type, "elf_loader_test") {
testonly = true
Expand Down
3 changes: 3 additions & 0 deletions starboard/loader_app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ static_library("installation_manager") {
]
}

# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms.
if (!is_host_win) {
target(gtest_target_type, "installation_manager_test") {
testonly = true
Expand Down Expand Up @@ -277,6 +278,7 @@ static_library("slot_management") {
}
}

# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms.
if (!is_host_win) {
target(gtest_target_type, "slot_management_test") {
testonly = true
Expand Down Expand Up @@ -326,6 +328,7 @@ static_library("reset_evergreen_update") {
deps = [ "//starboard" ]
}

# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms.
if (!is_host_win) {
target(gtest_target_type, "reset_evergreen_update_test") {
testonly = true
Expand Down

0 comments on commit 5eb5f80

Please sign in to comment.