Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Separate out modular and evergreen test targets"" #1878

Closed
wants to merge 1 commit into from
Closed

Revert "Revert "Separate out modular and evergreen test targets"" #1878

wants to merge 1 commit into from

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Oct 31, 2023 •
edited
Loading

Reverts #1873
Internal failures have been fixed

b/302008891

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Oct 31, 2023 •
edited
Loading

Datadog Report

Branch report: revert-1873-revert-1662-separate_eg_modular
Commit report: 514291f

❄️ cobalt: 0 Failed, 1 New Flaky, 29550 Passed, 1 Skipped, 13m 10.44s Wall Time

New Flaky Tests (1)

  • HandshakeWithClientCertCached - SSLServerSocketTest

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #1878 (514291f) into main (7e847b9) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1878   +/-   ##
=======================================
  Coverage   57.77%   57.77%           
=======================================
  Files        1915     1915           
  Lines       95111    95111           
=======================================
+ Hits        54946    54954    +8     
+ Misses      40165    40157    -8

see 4 files with indirect coverage changes

@niranjanyardi
Copy link
Contributor Author

This has some failures for raspi, android, talked to yavor, holden and made this new PR: #1918

@niranjanyardi niranjanyardi added the disable_on_device_test Disables on-device test on PR workflows label Nov 6, 2023
@kaidokert kaidokert deleted the revert-1873-revert-1662-separate_eg_modular branch November 29, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxve oxve oxve approved these changes

Assignees
No one assigned
Labels
disable_on_device_test Disables on-device test on PR workflows on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niranjanyardi @oxve