Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update javascript package dependencies #484

Merged

Conversation

iisakkirotko
Copy link
Collaborator

First commit is just bumping nodejs 14 -> 20 to check if build gets the same error as my local machine :)

Copy link
Collaborator Author

iisakkirotko commented Jan 25, 2024

@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from 1a589d6 to 268dbf0 Compare January 25, 2024 15:02
@iisakkirotko iisakkirotko marked this pull request as ready for review January 29, 2024 08:11
@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from 268dbf0 to b56de82 Compare January 29, 2024 13:47
@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from dea0811 to 6fe38f7 Compare January 29, 2024 13:47
@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from b56de82 to e641658 Compare January 30, 2024 10:29
@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from 6fe38f7 to d8d9409 Compare January 30, 2024 10:29
@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from d8d9409 to 59b3f21 Compare February 23, 2024 11:38
@iisakkirotko iisakkirotko changed the base branch from 01-25-feat_move_from_MathJax_to_Katex to master February 23, 2024 11:38
@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch 3 times, most recently from 8d6d259 to 068665d Compare February 26, 2024 14:32
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few changes (i don't think you can accept them, you need to run npm install to also update the lockfile)

packages/solara-vuetify-app/package.json Outdated Show resolved Hide resolved
packages/solara-widget-manager/package.json Outdated Show resolved Hide resolved
packages/solara-widget-manager8/package.json Outdated Show resolved Hide resolved
@maartenbreddels
Copy link
Contributor

There is still an vuetify version bump, you can remove that and update the lockfile please?

@iisakkirotko
Copy link
Collaborator Author

There is still an vuetify version bump, you can remove that and update the lockfile please?

Apparently there is, yeah... The new version matches https://github.com/widgetti/ipyvuetify/blob/7729f015ad384ab1549b25dc21175d3b7f246452/js/package.json#L64, though. Should I change it to what it was instead of that?

@maartenbreddels
Copy link
Contributor

That's the vue3/vuetify3 branch: https://github.com/widgetti/ipyvuetify/blob/vuetify3/js/package.json#L64

for vuetify 2 we use mario's branch

@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from aeb8952 to b51bcfc Compare March 5, 2024 14:11
@iisakkirotko
Copy link
Collaborator Author

@maartenbreddels So then all Vuetify versions match, correct? (I also did run npm install, but this produced no change in package-lock.json)

Also, if we want to keep our Vuetify versions in sync with ipyvuetify, perhaps we should hard fix them in both, instead of using the compatible with ~ operator? You can see here that currently npm picks the newest compatible version (i.e. 2.2.34) anyway.

@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from b51bcfc to 5bbd2ae Compare March 8, 2024 10:42
@iisakkirotko iisakkirotko dismissed maartenbreddels’s stale review March 8, 2024 13:07

requested changes have been implemented, as agreed in separate discussion

@iisakkirotko iisakkirotko force-pushed the 01-25-chore_update_javascript_package_dependencies branch from 5bbd2ae to a85771d Compare March 8, 2024 13:26
@maartenbreddels maartenbreddels force-pushed the 01-25-chore_update_javascript_package_dependencies branch from a85771d to 51f0883 Compare March 10, 2024 21:26
@iisakkirotko iisakkirotko merged commit c1b41c0 into master Mar 11, 2024
25 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants