Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move from MathJax to Katex #483

Conversation

iisakkirotko
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

iisakkirotko commented Jan 25, 2024

@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch 3 times, most recently from 6b6e9e8 to 8f96659 Compare January 25, 2024 11:30
@iisakkirotko iisakkirotko force-pushed the 01-24-fix_Mermaid_and_Math_rendering_in_Jupyter_Lab_and_VSCode branch from a2bc37d to 8d4fe2a Compare January 25, 2024 14:33
@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from 1a589d6 to 268dbf0 Compare January 25, 2024 15:02
@iisakkirotko iisakkirotko force-pushed the 01-24-fix_Mermaid_and_Math_rendering_in_Jupyter_Lab_and_VSCode branch from f26b0e4 to fc01053 Compare January 29, 2024 13:47
@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from 268dbf0 to b56de82 Compare January 29, 2024 13:47
@iisakkirotko iisakkirotko force-pushed the 01-24-fix_Mermaid_and_Math_rendering_in_Jupyter_Lab_and_VSCode branch from c8dde04 to f882941 Compare January 30, 2024 10:29
@iisakkirotko iisakkirotko force-pushed the 01-25-feat_move_from_MathJax_to_Katex branch from b56de82 to e641658 Compare January 30, 2024 10:29
@maartenbreddels
Copy link
Contributor

Please take a look at the merge conflicts, I guess it's that node typing line
What are the implications for bundle size? Is this an improvement?

And what are the top reasons for moving from mathjax to katex? I know @kolibril13 is a katex fan as well, maybe he also knows good reasons to switch.

@kolibril13
Copy link

katex got recommended to me by a friend, it's supposed to be fastest then mathjax.
https://katex.org/
I've never used it in a project before, so I cannot say much more about it.

@iisakkirotko
Copy link
Collaborator Author

iisakkirotko commented Feb 16, 2024

The benefit of KaTeX is mainly package size, compared to MathJax, which we used previously. Looking at the unpackaged size of the two on npm, you can see that the size of mathjax-full, which we use now, is ~34MB, while the size of KaTeX is ~4MB.

As @kolibril13 said, KaTeX seems to be faster than MathJax, but I think in comparison to MathJax 3, the difference is pretty minimal. Note that Jupyter still uses MathJax 2, which is much slower.

Some people say that support for some LaTeX features in KaTeX might be lacking, but I don't foresee any of these being something that sees very frequent use in Solara apps. You can take a look at the KaTeX support table here

…_VSCode' into 01-25-feat_move_from_MathJax_to_Katex
@maartenbreddels maartenbreddels merged commit e4918c9 into 01-24-fix_Mermaid_and_Math_rendering_in_Jupyter_Lab_and_VSCode Feb 16, 2024
25 checks passed
iisakkirotko added a commit that referenced this pull request Feb 23, 2024
* feat: move from MathJax to Katex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants