Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solara.server.jupyter.server_extension not activating #479

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: solara.server.jupyter.server_extension not activating #479

merged 1 commit into from
Jan 29, 2024

Conversation

iisakkirotko
Copy link
Collaborator

I can't say I figured out what broke this

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Jan 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

This was referenced Jan 24, 2024
Merged
Merged
Merged
Merged
@iisakkirotko @maartenbreddels
fix: solara.server.jupyter.server_extension not activating
080894e 
I can't say I figured out what broke this
@maartenbreddels maartenbreddels force-pushed the 01-24-fix_solara.server.jupyter.server_extension_not_activating branch from fa65a1a to 080894e Compare January 29, 2024 12:31
@maartenbreddels maartenbreddels mentioned this pull request Jan 29, 2024
Closed
@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Jan 29, 2024 •
edited
Loading

Merge activity

@iisakkirotko iisakkirotko merged commit a1125fb into master Jan 29, 2024
24 checks passed
maartenbreddels added a commit that referenced this pull request Jan 29, 2024
@maartenbreddels
refactor: split assets settings in server and non-server parts
da06303 
Based on:
 * #479
 * #480
 * #486

We decided that using the proxy and the cdn if the proxy is not used
is not only something to be used in solara server. In vscode
or colab, we cannot use the proxy, and need to use the cdn directly.
@maartenbreddels maartenbreddels mentioned this pull request Jan 29, 2024
Merged
maartenbreddels added a commit that referenced this pull request Jan 30, 2024
@maartenbreddels
refactor: split assets settings in server and non-server parts
0ad109c 
Based on:
 * #479
 * #480
 * #486

We decided that using the proxy and the cdn if the proxy is not used
is not only something to be used in solara server. In vscode
or colab, we cannot use the proxy, and need to use the cdn directly.
maartenbreddels added a commit that referenced this pull request Jan 30, 2024
@maartenbreddels
refactor: split assets settings in server and non-server parts (#487)
2e0b110 
Based on:
 * #479
 * #480
 * #486

We decided that using the proxy and the cdn if the proxy is not used
is not only something to be used in solara server. In vscode
or colab, we cannot use the proxy, and need to use the cdn directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iisakkirotko @maartenbreddels